linux-kernel - Re: [PATCH v3 2/8] tracing/ftrace: guard syscall probe with preempt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbd40019-9034-4aad-a632-f63f16a9c9e3@efficios.com>
Date: Tue, 8 Oct 2024 20:49:43 -0400
From: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Masami Hiramatsu <mhiramat@...nel.org>, linux-kernel@...r.kernel.org,
 Peter Zijlstra <peterz@...radead.org>, Alexei Starovoitov <ast@...nel.org>,
 Yonghong Song <yhs@...com>, "Paul E . McKenney" <paulmck@...nel.org>,
 Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
 Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Namhyung Kim <namhyung@...nel.org>,
 Andrii Nakryiko <andrii.nakryiko@...il.com>, bpf@...r.kernel.org,
 Joel Fernandes <joel@...lfernandes.org>, linux-trace-kernel@...r.kernel.org,
 Michael Jeanson <mjeanson@...icios.com>
Subject: Re: [PATCH v3 2/8] tracing/ftrace: guard syscall probe with
 preempt_notrace

On 2024-10-09 01:19, Steven Rostedt wrote:
> On Fri,  4 Oct 2024 10:58:12 -0400
> Mathieu Desnoyers <mathieu.desnoyers@...icios.com> wrote:
> 
>> +		      PARAMS(assign), PARAMS(print))			\
>> +static notrace void							\
>> +trace_event_raw_event_##call(void *__data, proto)			\
>> +{									\
>> +	guard(preempt_notrace)();					\
>> +	do_trace_event_raw_event_##call(__data, args);			\
>> +}
>> +
> 
> Do we really need to use "guard()" for a single line function? Why make the
> compiler do more work?
> 
> static notrace void							\
> trace_event_raw_event_##call(void *__data, proto)			\
> {									\
> 	preempt_disable_notrace();					\
> 	do_trace_event_raw_event_##call(__data, args);			\
> 	preempt_enable_notrace();					\
> }
> 
> Is more readable.

I don't care. I'll do it your way (for all 3 patches).

Thanks,

Mathieu

> 
> -- Steve

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com