linux-kernel - Re: [PATCH v3 5/8] tracing: Allow system call tracepoints to handle page faults

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74d621a3-5b82-4831-a875-7c04e56dec7b@efficios.com>
Date: Tue, 8 Oct 2024 20:56:51 -0400
From: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Masami Hiramatsu <mhiramat@...nel.org>, linux-kernel@...r.kernel.org,
 Peter Zijlstra <peterz@...radead.org>, Alexei Starovoitov <ast@...nel.org>,
 Yonghong Song <yhs@...com>, "Paul E . McKenney" <paulmck@...nel.org>,
 Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
 Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Namhyung Kim <namhyung@...nel.org>,
 Andrii Nakryiko <andrii.nakryiko@...il.com>, bpf@...r.kernel.org,
 Joel Fernandes <joel@...lfernandes.org>, linux-trace-kernel@...r.kernel.org,
 Michael Jeanson <mjeanson@...icios.com>
Subject: Re: [PATCH v3 5/8] tracing: Allow system call tracepoints to handle
 page faults

On 2024-10-09 01:23, Steven Rostedt wrote:
> On Fri,  4 Oct 2024 10:58:15 -0400
> Mathieu Desnoyers <mathieu.desnoyers@...icios.com> wrote:
> 
>> Use Tasks Trace RCU to protect iteration of system call enter/exit
>> tracepoint probes to allow those probes to handle page faults.
>>
>> In preparation for this change, all tracers registering to system call
>> enter/exit tracepoints should expect those to be called with preemption
>> enabled.
>>
>> This allows tracers to fault-in userspace system call arguments such as
>> path strings within their probe callbacks.
>>
>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
>> Cc: Michael Jeanson <mjeanson@...icios.com>
>> Cc: Steven Rostedt <rostedt@...dmis.org>
>> Cc: Masami Hiramatsu <mhiramat@...nel.org>
>> Cc: Peter Zijlstra <peterz@...radead.org>
>> Cc: Alexei Starovoitov <ast@...nel.org>
>> Cc: Yonghong Song <yhs@...com>
>> Cc: Paul E. McKenney <paulmck@...nel.org>
>> Cc: Ingo Molnar <mingo@...hat.com>
>> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
>> Cc: Mark Rutland <mark.rutland@....com>
>> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
>> Cc: Namhyung Kim <namhyung@...nel.org>
>> Cc: Andrii Nakryiko <andrii.nakryiko@...il.com>
>> Cc: bpf@...r.kernel.org
>> Cc: Joel Fernandes <joel@...lfernandes.org>
>> ---
>>   include/linux/tracepoint.h | 12 ++++++++++--
>>   init/Kconfig               |  1 +
>>   2 files changed, 11 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
>> index 014790495ad8..cefd44b7c91f 100644
>> --- a/include/linux/tracepoint.h
>> +++ b/include/linux/tracepoint.h
>> @@ -17,6 +17,7 @@
>>   #include <linux/errno.h>
>>   #include <linux/types.h>
>>   #include <linux/rcupdate.h>
>> +#include <linux/rcupdate_trace.h>
>>   #include <linux/tracepoint-defs.h>
>>   #include <linux/static_call.h>
>>   
>> @@ -107,6 +108,7 @@ void for_each_tracepoint_in_module(struct module *mod,
>>   #ifdef CONFIG_TRACEPOINTS
>>   static inline void tracepoint_synchronize_unregister(void)
>>   {
>> +	synchronize_rcu_tasks_trace();
>>   	synchronize_rcu();
>>   }
>>   #else
>> @@ -204,11 +206,17 @@ static inline struct tracepoint *tracepoint_ptr_deref(tracepoint_ptr_t *p)
>>   		if (!(cond))						\
>>   			return;						\
>>   									\
>> -		preempt_disable_notrace();				\
> 
> Should add a comment somewhere stating that the syscall version is to allow faults.

I plan to add this comment on top of __TO_TRACE:

+ *
+ * With @syscall=0, the tracepoint callback array dereference is
+ * protected by disabling preemption.
+ * With @syscall=1, the tracepoint callback array dereference is
+ * protected by Tasks Trace RCU, which allows probes to handle page
+ * faults.

Thanks,

Mathieu


> 
> -- Steve
> 
>> +		if (syscall)						\
>> +			rcu_read_lock_trace();				\
>> +		else							\
>> +			preempt_disable_notrace();			\
>>   									\
>>   		__DO_TRACE_CALL(name, TP_ARGS(args));			\
>>   									\
>> -		preempt_enable_notrace();				\
>> +		if (syscall)						\
>> +			rcu_read_unlock_trace();			\
>> +		else							\
>> +			preempt_enable_notrace();			\
>>   	} while (0)
>>   
>>   /*
>> diff --git a/init/Kconfig b/init/Kconfig
>> index fbd0cb06a50a..eedd0064fb36 100644
>> --- a/init/Kconfig
>> +++ b/init/Kconfig
>> @@ -1984,6 +1984,7 @@ config BINDGEN_VERSION_TEXT
>>   #
>>   config TRACEPOINTS
>>   	bool
>> +	select TASKS_TRACE_RCU
>>   
>>   source "kernel/Kconfig.kexec"
>>   
> 

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com