linux-kernel - Re: [PATCH v4 9/9] mm: Consolidate common checks in hugetlb_get_unmapped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202410081210.uNLbf3Jk-lkp@intel.com>
Date: Tue, 8 Oct 2024 13:37:25 +0800
From: kernel test robot <lkp@...el.com>
To: Oscar Salvador <osalvador@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc: oe-kbuild-all@...ts.linux.dev,
	Linux Memory Management List <linux-mm@...ck.org>,
	linux-kernel@...r.kernel.org, Peter Xu <peterx@...hat.com>,
	Muchun Song <muchun.song@...ux.dev>,
	David Hildenbrand <david@...hat.com>,
	Donet Tom <donettom@...ux.ibm.com>,
	Vlastimil Babka <vbabka@...e.cz>, Michal Hocko <mhocko@...e.com>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	Oscar Salvador <osalvador@...e.de>
Subject: Re: [PATCH v4 9/9] mm: Consolidate common checks in
 hugetlb_get_unmapped_area

Hi Oscar,

kernel test robot noticed the following build warnings:

[auto build test WARNING on s390/features]
[also build test WARNING on brauner-vfs/vfs.all akpm-mm/mm-everything linus/master v6.12-rc2 next-20241004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Oscar-Salvador/mm-mmap-Teach-generic_get_unmapped_area-_topdown-to-handle-hugetlb-mappings/20241007-155328
base:   https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
patch link:    https://lore.kernel.org/r/20241007075037.267650-10-osalvador%40suse.de
patch subject: [PATCH v4 9/9] mm: Consolidate common checks in hugetlb_get_unmapped_area
config: mips-cavium_octeon_defconfig (https://download.01.org/0day-ci/archive/20241008/202410081210.uNLbf3Jk-lkp@intel.com/config)
compiler: mips64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241008/202410081210.uNLbf3Jk-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410081210.uNLbf3Jk-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/linux/hugetlb.h:789,
                    from kernel/fork.c:53:
   arch/mips/include/asm/hugetlb.h: In function 'prepare_hugepage_range':
>> arch/mips/include/asm/hugetlb.h:20:24: warning: unused variable 'h' [-Wunused-variable]
      20 |         struct hstate *h = hstate_file(file);
         |                        ^


vim +/h +20 arch/mips/include/asm/hugetlb.h

50a41ff292fafe David Daney     2009-05-27  13  
78d6e4e8ea8700 Alexandre Ghiti 2018-10-26  14  #define __HAVE_ARCH_PREPARE_HUGEPAGE_RANGE
50a41ff292fafe David Daney     2009-05-27  15  static inline int prepare_hugepage_range(struct file *file,
50a41ff292fafe David Daney     2009-05-27  16  					 unsigned long addr,
50a41ff292fafe David Daney     2009-05-27  17  					 unsigned long len)
50a41ff292fafe David Daney     2009-05-27  18  {
50a41ff292fafe David Daney     2009-05-27  19  	unsigned long task_size = STACK_TOP;
50a41ff292fafe David Daney     2009-05-27 @20  	struct hstate *h = hstate_file(file);
50a41ff292fafe David Daney     2009-05-27  21  
50a41ff292fafe David Daney     2009-05-27  22  	if (len > task_size)
50a41ff292fafe David Daney     2009-05-27  23  		return -ENOMEM;
50a41ff292fafe David Daney     2009-05-27  24  	if (task_size - len < addr)
50a41ff292fafe David Daney     2009-05-27  25  		return -EINVAL;
50a41ff292fafe David Daney     2009-05-27  26  	return 0;
50a41ff292fafe David Daney     2009-05-27  27  }
50a41ff292fafe David Daney     2009-05-27  28  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki