linux-kernel - Re: [PATCH v2] drm/atmel_hlcdc: Fix uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3f22647-fef3-45d1-b8b7-52b0a988d0b3@microchip.com>
Date: Tue, 8 Oct 2024 05:38:14 +0000
From: <Manikandan.M@...rochip.com>
To: <advaitdhamorikar@...il.com>, <sam@...nborg.org>, <bbrezillon@...nel.org>,
	<maarten.lankhorst@...ux.intel.com>, <mripard@...nel.org>,
	<tzimmermann@...e.de>, <airlied@...il.com>, <simona@...ll.ch>,
	<Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
	<claudiu.beznea@...on.dev>
CC: <dri-devel@...ts.freedesktop.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <skhan@...uxfoundation.org>,
	<anupnewsmail@...il.com>, <lkp@...el.com>, <error27@...il.com>
Subject: Re: [PATCH v2] drm/atmel_hlcdc: Fix uninitialized variable

On 07/10/24 8:39 pm, Advait Dhamorikar wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> atmel_hlcdc_plane_update_buffers: may use an uninitialized
> sr variable when the if condition remains unsatisfied.
> The variable may contain an arbitrary value left from earlier computations.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <error27@...il.com>
> Closes: https://lore.kernel.org/r/202409240320.MZPgi3Up-lkp@intel.com/
> Signed-off-by: Advait Dhamorikar <advaitdhamorikar@...il.com>
Reviewed-by: Manikandan Muralidharan <manikandan.m@...rochip.com>
> ---
> v1->v2: add reported by and closes labels
> 
>   drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> index 4a7ba0918eca..4150c4d0b4f2 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> @@ -559,7 +559,7 @@ static void atmel_hlcdc_plane_update_buffers(struct atmel_hlcdc_plane *plane,
>          const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
>          struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
>          struct drm_framebuffer *fb = state->base.fb;
> -       u32 sr;
> +       u32 sr = 0;
>          int i;
> 
>          if (!dc->desc->is_xlcdc)
> --
> 2.34.1
> 

-- 
Thanks and Regards,
Manikandan M.