linux-kernel - Re: [PATCH] selftests/bpf: Add __init and __exit to the functions bpf_test_no_cfi_init()/bpf_test_no_cfi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e02d812-9955-462a-9316-197e27747eb3@kylinos.cn>
Date: Tue, 8 Oct 2024 09:11:18 +0800
From: Yaxiong Tian <tianyaxiong@...inos.cn>
To: Daniel Borkmann <daniel@...earbox.net>, martin.lau@...ux.dev,
 ast@...nel.org, andrii@...nel.org, shuah@...nel.org, hinker.li@...il.com
Cc: bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/bpf: Add __init and __exit to the functions
 bpf_test_no_cfi_init()/bpf_test_no_cfi_exit()


在 2024/10/2 20:15, Daniel Borkmann 写道:
> On 9/30/24 3:33 AM, Yaxiong Tian wrote:
>> From: Yaxiong Tian <iambestgod@...look.com>
>>
>> To save some running memory,Add __init and __exit to the
>> module load/unload functions.
>>
>> Signed-off-by: Yaxiong Tian <tianyaxiong@...inos.cn>
>> ---
>>   tools/testing/selftests/bpf/bpf_test_no_cfi/bpf_test_no_cfi.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git 
>> a/tools/testing/selftests/bpf/bpf_test_no_cfi/bpf_test_no_cfi.c 
>> b/tools/testing/selftests/bpf/bpf_test_no_cfi/bpf_test_no_cfi.c
>> index 948eb3962732..aa571ab3c6c6 100644
>> --- a/tools/testing/selftests/bpf/bpf_test_no_cfi/bpf_test_no_cfi.c
>> +++ b/tools/testing/selftests/bpf/bpf_test_no_cfi/bpf_test_no_cfi.c
>> @@ -56,7 +56,7 @@ static struct bpf_struct_ops test_no_cif_ops = {
>>       .owner = THIS_MODULE,
>>   };
>>   -static int bpf_test_no_cfi_init(void)
>> +static int __init bpf_test_no_cfi_init(void)
>>   {
>>       int ret;
>>   @@ -71,7 +71,7 @@ static int bpf_test_no_cfi_init(void)
>>       return ret;
>>   }
>>   -static void bpf_test_no_cfi_exit(void)
>> +static void __exit bpf_test_no_cfi_exit(void)
>>   {
>>   }
> Not that the memory saving matters too much in this context, but lets 
> also
> annotate bpf_testmod_init and bpf_testmod_exit while at it?
>
Of course, it will provide a reference for those who are not familiar 
with this part of the code.
> Thanks,
> Daniel