linux-kernel - Re: [PATCH v2] scsi: fnic: Use vzalloc() instead of vmalloc() and memset(0)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2D16B4A0-DC8F-4448-93B1-508FD9F92774@linux.dev>
Date: Tue, 8 Oct 2024 13:02:01 +0200
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Johannes Thumshirn <Johannes.Thumshirn@....com>
Cc: Satish Kharat <satishkh@...co.com>,
 Sesidhar Baddela <sebaddel@...co.com>,
 Karan Tilak Kumar <kartilak@...co.com>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] scsi: fnic: Use vzalloc() instead of vmalloc() and
 memset(0)

On 8. Oct 2024, at 12:25, Johannes Thumshirn wrote:
> On 08.10.24 11:53, Thorsten Blum wrote:
>> Use vzalloc() instead of vmalloc() followed by memset(0) to simplify the
>> functions fnic_trace_buf_init() and fnic_fc_trace_init().
>> 
>> Remove unnecessary unsigned long cast.
>> 
>> Compile-tested only.
>> 
>> Cc: Johannes Thumshirn <johannes.thumshirn@....com>
>> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
>> ---
>> Changes in v2:
>> - Remove unsigned long cast as suggested by Johannes Thumshirn
>> - Link to v1: https://lore.kernel.org/linux-kernel/20241007115840.2239-6-thorsten.blum@linux.dev/
>> ---
>>  drivers/scsi/fnic/fnic_trace.c | 14 +++-----------
>>  1 file changed, 3 insertions(+), 11 deletions(-)
>> 
>> diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c
>> index aaa4ea02fb7c..c2413e0e4eaa 100644
>> --- a/drivers/scsi/fnic/fnic_trace.c
>> +++ b/drivers/scsi/fnic/fnic_trace.c
>> @@ -485,7 +485,7 @@ int fnic_trace_buf_init(void)
>>   }
>> 
>>   fnic_trace_entries.page_offset =
>> - vmalloc(array_size(fnic_max_trace_entries,
>> + vzalloc(array_size(fnic_max_trace_entries,
>>     sizeof(unsigned long)));
> 
> Sorry for not having spotted it earlier, but all those 
> vzalloc(array_size(foo, bar)); calls can be turned into vcalloc(foo, bar);

No worries, but removing the unsigned long casts actually doesn't work:

drivers/scsi/fnic/fnic_trace.c:559:27: error: incompatible pointer to integer conversion assigning to 'unsigned long' from 'typeof (vzalloc_noprof(size_mul(((1UL) << 12), fnic_fc_trace_max_pages)))' (aka 'void *') [-Wint-conversion]
  559 |         fnic_fc_ctlr_trace_buf_p =
      |                                  ^
  560 |                 vzalloc(array_size(PAGE_SIZE, fnic_fc_trace_max_pages));
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

I'll submit a v3.

Thanks,
Thorsten