linux-kernel - Re: [PATCH v2 00/19] iommufd: Add VIOMMU infrastructure (Part-1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2567891-44dc-48d5-abd0-e3fcfa02a4e6@intel.com>
Date: Wed, 9 Oct 2024 15:20:57 +0800
From: Yi Liu <yi.l.liu@...el.com>
To: Nicolin Chen <nicolinc@...dia.com>
CC: <jgg@...dia.com>, <kevin.tian@...el.com>, <will@...nel.org>,
	<joro@...tes.org>, <suravee.suthikulpanit@....com>, <robin.murphy@....com>,
	<dwmw2@...radead.org>, <baolu.lu@...ux.intel.com>, <shuah@...nel.org>,
	<linux-kernel@...r.kernel.org>, <iommu@...ts.linux.dev>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kselftest@...r.kernel.org>,
	<eric.auger@...hat.com>, <jean-philippe@...aro.org>, <mdf@...nel.org>,
	<mshavit@...gle.com>, <shameerali.kolothum.thodi@...wei.com>,
	<smostafa@...gle.com>
Subject: Re: [PATCH v2 00/19] iommufd: Add VIOMMU infrastructure (Part-1)

On 2024/10/1 05:59, Nicolin Chen wrote:
> On Sun, Sep 29, 2024 at 03:16:55PM +0800, Yi Liu wrote:
>>>>> I feel these two might act somehow similarly to the two DIDs
>>>>> during nested translations?
>>>>
>>>> not quite the same. Is it possible that the ASID is the same for stage-1?
>>>> Intel VT-d side can have the pasid to be the same. Like the gIOVA, all
>>>> devices use the same ridpasid. Like the scenario I replied to Baolu[1],
>>>> do er choose to use different DIDs to differentiate the caches for the
>>>> two devices.
>>>
>>> On ARM, each S1 domain (either a normal stage-1 PASID=0 domain or
>>> an SVA PASID>0 domain) has a unique ASID.
>>
>> I see. Looks like ASID is not the PASID.
> 
> It's not. PASID is called Substream ID in SMMU term. It's used to
> index the PASID table. For cache invalidations, a PASID (ssid) is
> for ATC (dev cache) or PASID table entry invalidation only.

sure. Is there any relationship between PASID and ASID? Per the below
link, ASID is used to tag the TLB entries of an application. So it's
used in the SVA case. right?

https://developer.arm.com/documentation/102142/0100/Stage-2-translation


>>> So it unlikely has the
>>> situation of two identical ASIDs if they are on the same vIOMMU,
>>> because the ASID pool is per IOMMU instance (whether p or v).
>>>
>>> With two vIOMMU instances, there might be the same ASIDs but they
>>> will be tagged with different VMIDs.
>>>
>>>> [1]
>>>> https://lore.kernel.org/linux-iommu/4bc9bd20-5aae-440d-84fd-f530d0747c23@intel.com/
>>>
>>> Is "gIOVA" a type of invalidation that only uses "address" out of
>>> "PASID, DID and address"? I.e. PASID and DID are not provided via
>>> the invalidation request, so it's going to broadcast all viommus?
>>
>> gIOVA is just a term v.s. vSVA. Just want to differentiate it from vSVA. :)
>> PASID and DID are still provided in the invalidation.
> 
> I am still not getting this gIOVA. What it does exactly v.s. vSVA?
> And should RIDPASID be IOMMU_NO_PASID?
gIOVA is the IOVA in guest. vSVA just the SVA in guest. Maybe the confusion
comes why not use vIOVA instead of gIOVA. is it? I think you are clear
about IOVA v.s. SVA. :)

yes, RIDPASID is the IOMMU_NO_PASID although VT-d arch allows it to be non
IOMMU_NO_PASID.

-- 
Regards,
Yi Liu