linux-kernel - Re: [PATCH] usb: typec: qcom-pmic-typec: fix sink status being overwritten with RP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZwY_pVEKE-GsXIvw@kuha.fi.intel.com>
Date: Wed, 9 Oct 2024 11:32:37 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Jonathan Marek <jonathan@...ek.ca>
Cc: linux-arm-msm@...r.kernel.org,
	Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Caleb Connolly <caleb.connolly@...aro.org>,
	Guenter Roeck <linux@...ck-us.net>,
	"open list:QUALCOMM TYPEC PORT MANAGER DRIVER" <linux-usb@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: typec: qcom-pmic-typec: fix sink status being
 overwritten with RP_DEF

On Sat, Oct 05, 2024 at 10:41:46AM -0400, Jonathan Marek wrote:
> This line is overwriting the result of the above switch-case.
> 
> This fixes the tcpm driver getting stuck in a "Sink TX No Go" loop.
> 
> Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
> Signed-off-by: Jonathan Marek <jonathan@...ek.ca>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> index a747baa297849..c37dede62e12c 100644
> --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> @@ -432,7 +432,6 @@ static int qcom_pmic_typec_port_get_cc(struct tcpc_dev *tcpc,
>  			val = TYPEC_CC_RP_DEF;
>  			break;
>  		}
> -		val = TYPEC_CC_RP_DEF;
>  	}
>  
>  	if (misc & CC_ORIENTATION)
> -- 
> 2.45.1

-- 
heikki