linux-kernel - Re: [PATCH] arm64: dts: mediatek: mt8195: Fix dtbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1bb941b-cb6d-32c4-2cf9-268fc3f43bf9@mediatek.com>
Date: Wed, 9 Oct 2024 16:49:56 +0800
From: Macpaul Lin <macpaul.lin@...iatek.com>
To: Fei Shao <fshao@...omium.org>, Chunfeng Yun <chunfeng.yun@...iatek.com>,
	Jieyy Yang <jieyy.yang@...iatek.com>, Jian Yang <jian.yang@...iatek.com>,
	Jianguo Zhang <jianguo.zhang@...iatek.com>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
	<matthias.bgg@...il.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-mediatek@...ts.infradead.org>, Seiya Wang <seiya.wang@...iatek.com>,
	Tinghan Shen <tinghan.shen@...iatek.com>, Chunfeng Yun
	<chunfeng.yun@...iatek.com>, Alexandre Mergnat <amergnat@...libre.com>, "Bear
 Wang" <bear.wang@...iatek.com>, Pablo Sun <pablo.sun@...iatek.com>, "Macpaul
 Lin" <macpaul@...il.com>, Sen Chu <sen.chu@...iatek.com>, Chris-qj chen
	<chris-qj.chen@...iatek.com>, MediaTek Chromebook Upstream
	<Project_Global_Chrome_Upstream_Group@...iatek.com>, Chen-Yu Tsai
	<wenst@...omium.org>
Subject: Re: [PATCH] arm64: dts: mediatek: mt8195: Fix dtbs_check error for
 tphy



On 10/8/24 15:10, Fei Shao wrote:
> 	
> 
> External email : Please do not click links or open attachments until you 
> have verified the sender or the content.
> 
> On Tue, Oct 8, 2024 at 1:36 PM Macpaul Lin <macpaul.lin@...iatek.com> wrote:
>>
>> The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error.
>> The error message was:
>>   t-phy@...30000: 'power-domains' does not match any of the regexes:
>>     '^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
>> Fix this issue by dropping 'power-domains' of u3phy1 node.
>>
>> Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and evaluation board")
>> Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
>> ---
> 
> Apart from this, can you or Chunfeng confirm if we should make a
> similar change for MT8188[1]?
> 
> [1]: https://lore.kernel.org/all/20241004081218.55962-3-fshao@chromium.org/
> 
> Regards,
> Fei
> 

According to the suggestion and discussion in

[1]: 
https://lore.kernel.org/lkml/20241008-disorder-slacking-d8196ceb68f7@spud/T/#mccf978d76f52cc26970f3f3be6120055e4698fe6

I think adding 'power-domains' to PCIE node of MT8188 is okay.

Thanks
Macpaul Lin