linux-kernel - Re: [PATCH v3?] ASoC: codecs: aw88399: Fix error handling in aw_dev_get_dsp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbbe290b-4dd4-4a65-acfb-8150b621a5c7@web.de>
Date: Wed, 9 Oct 2024 13:12:21 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Zhu Jun <zhujun2@...s.chinamobile.com>, linux-sound@...r.kernel.org,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Heiko Stübner <heiko@...ech.de>,
 Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Nathan Chancellor <nathan@...nel.org>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 Weidong Wang <wangweidong.a@...nic.com>
Subject: Re: [PATCH v3?] ASoC: codecs: aw88399: Fix error handling in
 aw_dev_get_dsp_status()

> Changed the error handling in aw_dev_get_dsp_status to return -EPERM directly
> instead of setting it to a variable.

* How do you think about to choose an imperative wording for an improved change description?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n94

* Would you like to add any tags (like “Fixes” and “Cc”) accordingly?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n145

…
> ---
> V1 -> V2:
> - add a dot after the commit
> - modify commit info

Can it be that higher version numbers would be more appropriate according to
the evolving patch review?

Regards,
Markus