linux-kernel - Re: [PATCH v3?] ASoC: codecs: aw88399: Fix error handling in aw_dev_get_dsp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZwZ7Zf0VCvert7Ya@finisterre.sirena.org.uk>
Date: Wed, 9 Oct 2024 13:47:33 +0100
From: Mark Brown <broonie@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Zhu Jun <zhujun2@...s.chinamobile.com>, linux-sound@...r.kernel.org,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Heiko Stübner <heiko@...ech.de>,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Nathan Chancellor <nathan@...nel.org>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>,
	Weidong Wang <wangweidong.a@...nic.com>
Subject: Re: [PATCH v3?] ASoC: codecs: aw88399: Fix error handling in
 aw_dev_get_dsp_status()

On Wed, Oct 09, 2024 at 01:12:21PM +0200, Markus Elfring wrote:
> > Changed the error handling in aw_dev_get_dsp_status to return -EPERM directly
> > instead of setting it to a variable.
> 
> * How do you think about to choose an imperative wording for an improved change description?

Feel free to ignore Markus, he has a long history of sending
unhelpful review comments and continues to ignore repeated requests
to stop.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)