linux-kernel - Re: [PATCH v6 2/4] i2c: npcm: Modify the client address assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZwkvBFHS1m3N2yoW@smile.fi.intel.com>
Date: Fri, 11 Oct 2024 16:58:28 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Tyrone Ting <warp5tw@...il.com>
Cc: avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com,
	venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com,
	andi.shyti@...nel.org, wsa@...nel.org, rand.sec96@...il.com,
	wsa+renesas@...g-engineering.com, tali.perry@...oton.com,
	Avi.Fishman@...oton.com, tomer.maimon@...oton.com,
	KWLIU@...oton.com, JJLIU0@...oton.com, kfting@...oton.com,
	openbmc@...ts.ozlabs.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/4] i2c: npcm: Modify the client address assignment

On Fri, Oct 11, 2024 at 09:44:42PM +0800, Tyrone Ting wrote:
> > On Fri, Oct 11, 2024 at 01:52:29PM +0800, Tyrone Ting wrote:

...

> > > +             if (bus->dest_addr & I2C_M_RD)
> >
> > Redundant.
> 
> Just to double check. Is the code "if (bus->dest_addr & I2C_M_RD)" redundant?

Yes.

> > > +                     bus->dest_addr &= ~I2C_M_RD;

-- 
With Best Regards,
Andy Shevchenko