linux-kernel - RE: [PATCH v3] irqchip/renesas-rzg2l: Fix missing put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TYCPR01MB120933C3D649803424D94A9EEC2792@TYCPR01MB12093.jpnprd01.prod.outlook.com>
Date: Fri, 11 Oct 2024 13:59:16 +0000
From: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
To: Markus Elfring <Markus.Elfring@....de>, Geert Uytterhoeven
	<geert@...ux-m68k.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>
CC: Geert Uytterhoeven <geert+renesas@...der.be>, Thomas Gleixner
	<tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>, Chris
 Paterson <Chris.Paterson2@...esas.com>, Biju Das
	<biju.das.jz@...renesas.com>, Prabhakar Mahadev Lad
	<prabhakar.mahadev-lad.rj@...renesas.com>, Marc Zyngier <maz@...nel.org>
Subject: RE: [PATCH v3] irqchip/renesas-rzg2l: Fix missing put_device

Hi Markus,

thanks for your feedback.

> From: Markus Elfring <Markus.Elfring@....de>
> Sent: Thursday, October 10, 2024 7:18 PM
> Subject: Re: [PATCH v3] irqchip/renesas-rzg2l: Fix missing put_device
> 
> >>> rzg2l_irqc_common_init calls of_find_device_by_node, but the
> >>> corresponding put_device call is missing.
> >>>
> >>> Make sure we call put_device when failing.
> >>>
> >>> "make coccicheck" will complain about a missing put_device before
> >>> successfully returning from rzg2l_irqc_common_init, however, that's
> >>> a false positive.
> >>>
> >>> Fixes: 3fed09559cd8 ("irqchip: Add RZ/G2L IA55 Interrupt Controller driver")
> >>
> >> Might the application of scope-based resource management become more
> >> interesting accordingly?
> >
> > No, as explained in the comments:
> >
> >>> +       /*
> >>> +        * coccicheck complains about a missing put_device call before returning, but it's a false
> >>> +        * positive. We still need &pdev->dev after successfully returning from this function.
> >>> +        */
> 
> Please reconsider the applicability of mentioned programming interfaces once more
> (as an evolving software design alternative for goto chains).
> https://elixir.bootlin.com/linux/v6.12-rc2/source/include/linux/device.h#L1239

I can give it a shot. I'll send a new version shortly.

Kind regards,
Fab

> 
> Regards,
> Markus