linux-kernel - Re: [PATCH] mm/zsmalloc: Use memcpy_from/to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOuPNLjUx1gXLWeoNCaxsJVEwwVO8-zikErEnDm1e4pMyFFBVA@mail.gmail.com>
Date: Fri, 11 Oct 2024 20:11:36 +0530
From: Pintu Agarwal <pintu.ping@...il.com>
To: Sergey Senozhatsky <senozhatsky@...omium.org>
Cc: Pintu Kumar <quic_pintu@...cinc.com>, minchan@...nel.org, akpm@...ux-foundation.org, 
	willy@...radead.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org, 
	joe@...ches.com, skhan@...uxfoundation.org
Subject: Re: [PATCH] mm/zsmalloc: Use memcpy_from/to_page whereever possible

On Fri, 11 Oct 2024 at 07:30, Sergey Senozhatsky
<senozhatsky@...omium.org> wrote:
>
> On (24/10/10 23:21), Pintu Kumar wrote:
> [..]
> > @@ -1511,10 +1501,10 @@ static void zs_object_copy(struct size_class *class, unsigned long dst,
> >               d_size -= size;
> >
> >               /*
> > -              * Calling kunmap_atomic(d_addr) is necessary. kunmap_atomic()
> > -              * calls must occurs in reverse order of calls to kmap_atomic().
> > -              * So, to call kunmap_atomic(s_addr) we should first call
> > -              * kunmap_atomic(d_addr). For more details see
> > +              * Calling kunmap_local(d_addr) is necessary. kunmap_local()
> > +              * calls must occurs in reverse order of calls to kmap_local_page().
> > +              * So, to call kunmap_local(s_addr) we should first call
> > +              * kunmap_local(d_addr). For more details see
> >                * Documentation/mm/highmem.rst.
> >                */
>
> I'd prefer this entire comment to be dropped.
Oh I thought the below code for k[un]map_local[_page] stills exists,
so the comments are still valid.
Ok I will remove it in the next patchset.
Looks like there are a few more code improvements possible.

Thank you,
Pintu