linux-kernel - Re: [PATCH] mm/zsmalloc: Use memcpy_from/to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241011020037.GB1279924@google.com>
Date: Fri, 11 Oct 2024 11:00:37 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Pintu Kumar <quic_pintu@...cinc.com>
Cc: minchan@...nel.org, senozhatsky@...omium.org, akpm@...ux-foundation.org,
	willy@...radead.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, joe@...ches.com,
	skhan@...uxfoundation.org, pintu.ping@...il.com
Subject: Re: [PATCH] mm/zsmalloc: Use memcpy_from/to_page whereever possible

On (24/10/10 23:21), Pintu Kumar wrote:
[..]
> @@ -1511,10 +1501,10 @@ static void zs_object_copy(struct size_class *class, unsigned long dst,
>  		d_size -= size;
>  
>  		/*
> -		 * Calling kunmap_atomic(d_addr) is necessary. kunmap_atomic()
> -		 * calls must occurs in reverse order of calls to kmap_atomic().
> -		 * So, to call kunmap_atomic(s_addr) we should first call
> -		 * kunmap_atomic(d_addr). For more details see
> +		 * Calling kunmap_local(d_addr) is necessary. kunmap_local()
> +		 * calls must occurs in reverse order of calls to kmap_local_page().
> +		 * So, to call kunmap_local(s_addr) we should first call
> +		 * kunmap_local(d_addr). For more details see
>  		 * Documentation/mm/highmem.rst.
>  		 */

I'd prefer this entire comment to be dropped.