linux-kernel - Re: [PATCH v4 RESEND] Docs/zh_CN: Translate physical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc144f6b-ad35-461e-a8a0-0395c9e69b46@gmail.com>
Date: Fri, 11 Oct 2024 10:56:58 +0900
From: Akira Yokosawa <akiyks@...il.com>
To: corbet@....net, jiang.kun2@....com.cn
Cc: alexs@...nel.org, fan.yu9@....com.cn, he.peilin@....com.cn,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 mudongliangabcd@...il.com, qiu.yutan@....com.cn, seakeel@...il.com,
 siyanteng@...ngson.cn, tu.qiang35@....com.cn, wang.yaxin@....com.cn,
 xu.xin16@....com.cn, zhang.yunkai@....com.cn
Subject: Re: [PATCH v4 RESEND] Docs/zh_CN: Translate physical_memory.rst to
 Simplified Chinese

On Wed, 09 Oct 2024 10:15:45 -0600, Jonathan Corbet wrote:
> <jiang.kun2@....com.cn> writes:
> 
>> From: Yaxin Wang <wang.yaxin@....com.cn>
>>
>> This patch translates the "physical_memory.rst" document into
>> Simplified Chinese to improve accessibility for Chinese-speaking
>> developers and users.
>>
>> The translation was done with attention to technical accuracy
>> and readability, ensuring that the document remains informative
>> and useful in its translated form.
>>
>> Signed-off-by: Yaxin Wang <wang.yaxin@....com.cn>
> 
> So that is not you.  If you are passing on a patch written by somebody
> else, you need to add your own Signed-off-by tag as well.
> 
> I would love it if somebody could review this...

Not only that, this is not ready for review.  It can't be applied by
"git am".  juang.kun2, you need to use a capable email client.

As this is "v4 RESEND" and you've been failing to see the problem,
I'm expanding on what you are missing.

Excerpt of email header fields of your patch:

----------------------------
X-Mailer: Zmail v1.0
[...]
Mime-Version: 1.0
[...]
Content-Type: text/plain;
	charset="UTF-8"
----------------------------

There is no "Content-Transer-Encoding:" field.  Unfortunate for you,
7bit is assumed by default, which is incompatible with UTF-8.

A known-to-work option for you is to use "git send email" for submitting
patches with UTF-8 charset.

It will generate a proper set of herder fields for such patches, e.g.:

-------------------------------------------
X-Mailer: git-send-email 2.43.0
[...]
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
-------------------------------------------

, which should be good enough for "git am".

        Thanks, Akira