linux-kernel - Re: [PATCH v6 1/2] x86, KVM:SVM: Move sev specific parsing into arch/x86/virt/svm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07b4dd67-9e09-eb0c-86d2-92fa68938129@amd.com>
Date: Fri, 11 Oct 2024 12:08:34 -0500
From: "Paluri, PavanKumar" <papaluri@....com>
To: Borislav Petkov <bp@...en8.de>, Tom Lendacky <thomas.lendacky@....com>
Cc: linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-coco@...ts.linux.dev, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Dave Hansen <dave.hansen@...ux.intel.com>,
 Eric Van Tassell <Eric.VanTassell@....com>,
 Ashish Kalra <ashish.kalra@....com>, Michael Roth <michael.roth@....com>,
 "H . Peter Anvin" <hpa@...or.com>, Peter Zijlstra <peterz@...radead.org>,
 Dhaval Giani <dhaval.giani@....com>
Subject: Re: [PATCH v6 1/2] x86, KVM:SVM: Move sev specific parsing into
 arch/x86/virt/svm

Hello Boris,

On 10/11/2024 11:59 AM, Borislav Petkov wrote:
> On Fri, Oct 11, 2024 at 11:55:14AM -0500, Tom Lendacky wrote:
>> Ah, that makes more sense. Looks like he's missing the include for
>> linux/cache.h 
> 
> "Changelog:
> =========
> v5:
> ...
>   * Remove <asm/cache.h> stray header introduced in the previous
>     versions because of __read_mostly attribute that is now moved into
>     virt/svm/cmdline.c"
> 

Yes, I am very sorry. I should have done a progressive build, which
could have helped me in spotting this issue.

This changelog points at removing <asm/cache.h> from
arch/x86/include/asm/sev-common.h (where __read_mostly was previously
present) and forgot to include this header to where it is now relocated
to. I will address this. On building the patchset (1 and 2 together), I
do not see the error, so this should have occurred on just building
Patch #1.

Thanks for the review.
Pavan