linux-kernel - Re: [PATCH] selftests/ftrace: Fix check of return value in fgraph-retval.tc test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e1e59650-0c9d-4100-8e6a-be640caea281@linuxfoundation.org>
Date: Fri, 11 Oct 2024 16:47:56 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Steven Rostedt <rostedt@...dmis.org>, LKML
 <linux-kernel@...r.kernel.org>,
 Linux Trace Kernel <linux-trace-kernel@...r.kernel.org>,
 linux-kselftest@...r.kernel.org
Cc: Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Shuah Khan <shuah@...nel.org>, Donglin Peng <pengdonglin@...omi.com>,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests/ftrace: Fix check of return value in
 fgraph-retval.tc test

On 10/11/24 11:20, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@...dmis.org>
> 
> The addition of recording both the function name and return address to the
> function graph tracer updated the selftest to check for "=-5" from "= -5".
> But this causes the test to fail on certain configs, as "= -5" is still a
> value that can be returned if function addresses are not enabled (older kernels).
> 
> Check for both "=-5" and " -5" as a success value.
> 
> Fixes: 21e92806d39c6 ("function_graph: Support recording and printing the function return address")
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> ---
> 
> Shuah, this update is only for changes in my tree, so you do not need to add it.

Noted. Thank you.

thanks,
-- Shuah