linux-kernel - Re: [PATCH net-next] net: vlan: Use vlan_prio instead of vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241011154918.477cd612@kernel.org>
Date: Fri, 11 Oct 2024 15:49:18 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Yajun Deng <yajun.deng@...ux.dev>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 aleksander.lobakin@...el.com, johannes.berg@...el.com,
 kory.maincent@...tlin.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: vlan: Use vlan_prio instead of vlan_qos
 in mapping

On Wed,  9 Oct 2024 21:23:02 +0800 Yajun Deng wrote:
> The vlan_qos member is used to save the vlan qos, but we only save the
> priority. Also, we will get the priority in vlan netlink and proc.
> So we can just save the vlan priority using vlan_prio.
> 
> Defined VLAN_PRIO_MAX to limit the vlan priority to a maximum of 7.
> For flexibility, we introduced vlan_dev_get_egress_priority helper
> function.

The motivation is not clear, you don't explain how you tested, and
haven't added any selftests.
-- 
pw-bot: cr