linux-kernel - Re: [PATCHv6 bpf-next 14/16] selftests/bpf: Scale down uprobe multi consumer test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZ0gOEdYtA5FdZxT_R3mBGBUrGwpvWaMrVQ2AP=bw1c-w@mail.gmail.com>
Date: Thu, 10 Oct 2024 19:27:47 -0700
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Jiri Olsa <jolsa@...nel.org>
Cc: Oleg Nesterov <oleg@...hat.com>, Peter Zijlstra <peterz@...radead.org>, 
	Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	Andrii Nakryiko <andrii@...nel.org>, bpf@...r.kernel.org, Martin KaFai Lau <kafai@...com>, 
	Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, 
	John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...omium.org>, 
	Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>, 
	Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu <mhiramat@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCHv6 bpf-next 14/16] selftests/bpf: Scale down uprobe multi
 consumer test

On Thu, Oct 10, 2024 at 1:12 PM Jiri Olsa <jolsa@...nel.org> wrote:
>
> We have currently 2 uprobes and 2 uretprobes and we are about
> to add sessions uprobes in following change, which makes the
> test time unsuitable for CI even with threads.
>
> It's enough for the test to have just 1 uprobe and 1 uretprobe.
>
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---
>  .../bpf/prog_tests/uprobe_multi_test.c        | 57 ++++++++-----------
>  .../bpf/progs/uprobe_multi_consumers.c        | 16 +-----
>  2 files changed, 25 insertions(+), 48 deletions(-)
>

[...]

>         /* 'before' is each, we attach uprobe for every set idx */
> -       for (idx = 0; idx < 4; idx++) {
> +       for (idx = 0; idx < 1; idx++) {
>                 if (test_bit(idx, before)) {
>                         if (!ASSERT_OK(uprobe_attach(skel, idx), "uprobe_attach_before"))
>                                 goto cleanup;
> @@ -866,18 +858,18 @@ static int consumer_test(struct uprobe_multi_consumers *skel,
>         if (!ASSERT_EQ(err, 0, "uprobe_consumer_test"))
>                 goto cleanup;
>
> -       for (idx = 0; idx < 4; idx++) {
> +       for (idx = 0; idx < 1; idx++) {

here and everywhere else, either idx <= 1 or idx < 2, no?

>                 const char *fmt = "BUG";
>                 __u64 val = 0;
>
> -               if (idx < 2) {
> +               if (idx == 0) {
>                         /*
>                          * uprobe entry
>                          *   +1 if define in 'before'
>                          */
>                         if (test_bit(idx, before))
>                                 val++;
> -                       fmt = "prog 0/1: uprobe";
> +                       fmt = "prog 0: uprobe";
>                 } else {
>                         /*
>                          * to trigger uretprobe consumer, the uretprobe needs to be installed,

[...]