linux-kernel - Re: [PATCHv6 bpf-next 16/16] selftests/bpf: Add threads to consumer test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4Bza3VLNKSdRQJtODAwmb4jZ85wq46QHBnXwzu_M+um9d_g@mail.gmail.com>
Date: Thu, 10 Oct 2024 19:35:50 -0700
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Jiri Olsa <jolsa@...nel.org>
Cc: Oleg Nesterov <oleg@...hat.com>, Peter Zijlstra <peterz@...radead.org>, 
	Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	Andrii Nakryiko <andrii@...nel.org>, bpf@...r.kernel.org, Martin KaFai Lau <kafai@...com>, 
	Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, 
	John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...omium.org>, 
	Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>, 
	Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu <mhiramat@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCHv6 bpf-next 16/16] selftests/bpf: Add threads to consumer test

On Thu, Oct 10, 2024 at 1:13 PM Jiri Olsa <jolsa@...nel.org> wrote:
>
> With recent uprobe fix [1] the sync time after unregistering uprobe is
> much longer and prolongs the consumer test which creates and destroys
> hundreds of uprobes.
>
> This change adds 16 threads (which fits the test logic) and speeds up
> the test.
>
> Before the change:
>
>   # perf stat --null ./test_progs -t uprobe_multi_test/consumers
>   #421/9   uprobe_multi_test/consumers:OK
>   #421     uprobe_multi_test:OK
>   Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED
>
>    Performance counter stats for './test_progs -t uprobe_multi_test/consumers':
>
>         28.818778973 seconds time elapsed
>
>          0.745518000 seconds user
>          0.919186000 seconds sys
>
> After the change:
>
>   # perf stat --null ./test_progs -t uprobe_multi_test/consumers 2>&1
>   #421/9   uprobe_multi_test/consumers:OK
>   #421     uprobe_multi_test:OK
>   Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED
>
>    Performance counter stats for './test_progs -t uprobe_multi_test/consumers':
>
>          3.504790814 seconds time elapsed
>
>          0.012141000 seconds user
>          0.751760000 seconds sys
>
> [1] commit 87195a1ee332 ("uprobes: switch to RCU Tasks Trace flavor for better performance")
>
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---
>  .../bpf/prog_tests/uprobe_multi_test.c        | 98 +++++++++++++++----
>  1 file changed, 80 insertions(+), 18 deletions(-)
>

OK, LGTM

Acked-by: Andrii Nakryiko <andrii@...nel.org>

[...]