linux-kernel - Re: [PATCH] platform/chrome: cross_ec_type: fix missing fwnode reference decrement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZwiYzGzbfK4rmOxq@tzungbi-laptop>
Date: Fri, 11 Oct 2024 11:17:32 +0800
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Prashant Malani <pmalani@...omium.org>,
	Benson Leung <bleung@...omium.org>,
	Guenter Roeck <groeck@...omium.org>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Enric Balletbo i Serra <eballetbo@...nel.org>,
	chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] platform/chrome: cross_ec_type: fix missing fwnode
 reference decrement

On Wed, Oct 09, 2024 at 09:00:41PM +0200, Javier Carrasco wrote:
> On 09/10/2024 20:55, Javier Carrasco wrote:
> > By the way, I wonder why all error paths are redirected to the same
> > label to unregister ports, even before registering them (which seems to
> > be harmless because unregistered ports are ignored, but still). With this

I don't know the context a lot.  But it looks like just a way to unregister
the registered ones in the error path.

> Small typo in the description, should be cross_ec_typec (last c is
> missing). I will fix that for v2, but I will wait for feedback and
> reviews to this first version.

Also cross -> cros.  Otherwise, the fix looks good to me.