linux-kernel - Re: [PATCH v1 01/10] dt-bindings: media: mediatek: add camsys device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d38e2393c648a769d7258f102b3c89b512a544d4.camel@mediatek.com>
Date: Fri, 11 Oct 2024 03:20:02 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "sumit.semwal@...aro.org" <sumit.semwal@...aro.org>,
	"christian.koenig@....com" <christian.koenig@....com>, "mchehab@...nel.org"
	<mchehab@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Shu-hsiang Yang (楊舒翔)
	<Shu-hsiang.Yang@...iatek.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"yunkec@...omium.org" <yunkec@...omium.org>, "linaro-mm-sig@...ts.linaro.org"
	<linaro-mm-sig@...ts.linaro.org>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, Yaya Chang (張雅清)
	<Yaya.Chang@...iatek.com>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Teddy Chen (陳乾元) <Teddy.Chen@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "hidenorik@...omium.org"
	<hidenorik@...omium.org>, Shun-Yi Wang (王順億)
	<Shun-Yi.Wang@...iatek.com>
Subject: Re: [PATCH v1 01/10] dt-bindings: media: mediatek: add camsys device

Hi, Shu-hsiang:

On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> 1. Add camera isp7x module device document
> 2. Add camera interface device document
> 
> Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@...iatek.com>
> ---

[snip]

> diff --git a/Documentation/devicetree/bindings/media/mediatek/mediatek,seninf.yaml b/Documentation/devicetree/bindings/media/mediatek/mediatek,seninf.yaml
> new file mode 100644
> index 000000000000..37d94138c558
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek/mediatek,seninf.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (c) 2024 MediaTek Inc.
> +
> +%YAML 1.2
> +---
> +$id: https://urldefense.com/v3/__http://devicetree.org/schemas/media/mediatek/mediatek,seninf.yaml*__;Iw!!CTRNKA9wMg0ARbw!jkHmqtxOst6Dv88RaE-ss9VaxKxFo4FuPl1smXTEnkiijU7jS9nkYGBPoLr8g4Ji2dZpb_7LHWrLpIyu2qoPVkLta9M$ 
> +$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!jkHmqtxOst6Dv88RaE-ss9VaxKxFo4FuPl1smXTEnkiijU7jS9nkYGBPoLr8g4Ji2dZpb_7LHWrLpIyu2qoPfKVBdTw$ 
> +
> +title: The seninf unit of MediaTek ISP system
> +
> +maintainers:
> +  - Shu-hsiang Yang <shu-hsiang.yang@...iatek.com>
> +  - Shun-yi Wang <shun-yi.wang@...iatek.com>
> +  - Teddy Chen <teddy.chen@...iatek.com>
> +
> +description:
> +  MediaTek seninf is the MIPI-CSI2 port for seninf-core in MediaTek SoC.
> +  These ports provide the optional capability to define endpoints and set RX
> +  controller for camera sensors.
> +
> +properties:
> +  compatible:
> +    const: mediatek,seninf
> +
> +  csi-port:
> +    description: MediaTek CSI Rx port name
> +    $ref: /schemas/types.yaml#/definitions/string
> +
> +  port:
> +    description:
> +      MediaTek sensor interface endpoints for one sensor bus.
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +
> +    properties:
> +      "#address-cells":
> +        const: 1
> +      "#size-cells":
> +        const: 0
> +
> +    patternProperties:
> +      "^endpoint(@[0-9]+)?$":
> +        description:
> +          CSI port for one sensor endpoint configuration.
> +          Consider one sensor bus can support differet links for MIPI PHY.
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +        properties:
> +          data-lanes:
> +            items:
> +              enum: [1, 2, 3, 4]
> +            maxItems: 4
> +
> +    additionalProperties: false
> +
> +required:
> +  - compatible
> +  - csi-port
> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    seninf_top {
> +      seninf_csi_port_0: seninf_csi_port_0 {
> +        compatible = "mediatek,seninf";
> +        csi-port = "0A";

This device has no reg property, so it's a virtual device not a real device.
binding document is used to describe a real hardware device, so drop this binding document.

There is another seninf device [1] which is upstreaming.
Even though it's not upstreamed yet, it have been reviewed.
You may take it as a reference.

[1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=874617

Regards,
CK

> +        port {
> +          #address-cells = <1>;
> +          #size-cells = <0>;
> +
> +          seninf_csi_port_0_in_1: endpoint {
> +            data-lanes = <1 2>;
> +            link-frequencies = /bits/ 64 <1440000000 624000000>;
> +            remote-endpoint = <&sensor0_out_1>;
> +          };
> +
> +          seninf_csi_port_0_in_2: endpoint@2 {
> +            reg = <2>;
> +            data-lanes = <1 2>;
> +            link-frequencies = /bits/ 64 <336000000 207000000>;
> +            remote-endpoint = <&sensor0_out_2>;
> +          };
> +        };
> +      };
> +    };
> +
> +...