linux-kernel - Re: [PATCH v1 04/10] media: platform: mediatek: add isp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0dc5b6c767e340a8fccbfb812731371c0a0c6c45.camel@mediatek.com>
Date: Fri, 11 Oct 2024 05:40:57 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "sumit.semwal@...aro.org" <sumit.semwal@...aro.org>,
	"christian.koenig@....com" <christian.koenig@....com>, "mchehab@...nel.org"
	<mchehab@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Shu-hsiang Yang (楊舒翔)
	<Shu-hsiang.Yang@...iatek.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"yunkec@...omium.org" <yunkec@...omium.org>, "linaro-mm-sig@...ts.linaro.org"
	<linaro-mm-sig@...ts.linaro.org>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, Yaya Chang (張雅清)
	<Yaya.Chang@...iatek.com>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Teddy Chen (陳乾元) <Teddy.Chen@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "hidenorik@...omium.org"
	<hidenorik@...omium.org>, Shun-Yi Wang (王順億)
	<Shun-Yi.Wang@...iatek.com>
Subject: Re: [PATCH v1 04/10] media: platform: mediatek: add isp_7x cam-raw
 unit

Hi, Shu-hsiang:

On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> Introduces the ISP pipeline driver for the MediaTek ISP raw and yuv
> modules. Key functionalities include data processing, V4L2 integration,
> resource management, debug support, and various control operations.
> Additionally, IRQ handling, platform device management, and MediaTek
> ISP DMA format support are also included.
> 
> Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@...iatek.com>
> ---

[snip]

> +
> +static irqreturn_t mtk_thread_irq_raw(int irq, void *data)
> +{
> +	struct mtk_raw_device *raw_dev = (struct mtk_raw_device *)data;
> +	struct mtk_camsys_irq_info irq_info;
> +
> +	if (unlikely(atomic_cmpxchg(&raw_dev->is_fifo_overflow, 1, 0)))
> +		dev_info(raw_dev->dev, "msg fifo overflow\n");
> +
> +	while (kfifo_len(&raw_dev->msg_fifo) >= sizeof(irq_info)) {
> +		int len = kfifo_out(&raw_dev->msg_fifo, &irq_info, sizeof(irq_info));
> +
> +		WARN_ON(len != sizeof(irq_info));
> +
> +		dev_dbg(raw_dev->dev, "ts=%llu irq_type %d, req:%d/%d\n",
> +			irq_info.ts_ns, irq_info.irq_type,
> +			irq_info.frame_idx_inner, irq_info.frame_idx);
> +
> +		/* error case */
> +		if (unlikely(irq_info.irq_type == (1 << CAMSYS_IRQ_ERROR))) {
> +			raw_handle_error(raw_dev, &irq_info);
> +			continue;
> +		}
> +
> +		/* normal case */
> +		/* inform interrupt information to camsys controller */
> +		mtk_camsys_isr_event(raw_dev->cam, CAMSYS_ENGINE_RAW,
> +				     raw_dev->id, &irq_info);

mtk_camsys_isr_event() is not defined in this patch but defined in [8/10] patch.
This is weird to use a function defined in future.
Define this function in this patch or previous patch.

Regards,
CK

> +	}
> +
> +	return IRQ_HANDLED;
> +}
> +