linux-kernel - Re: [PATCH] ASoC: fsl_esai: change dev_warn to dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c590d45-ba6e-48dc-aa32-e70029885867@nxp.com>
Date: Fri, 11 Oct 2024 11:00:34 +0300
From: Iuliana Prodan <iuliana.prodan@....com>
To: Shengjiu Wang <shengjiu.wang@....com>, shengjiu.wang@...il.com,
 Xiubo.Lee@...il.com, festevam@...il.com, nicoleotsuka@...il.com,
 lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz, tiwai@...e.com,
 alsa-devel@...a-project.org, linuxppc-dev@...ts.ozlabs.org,
 linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: fsl_esai: change dev_warn to dev_dbg in irq handler

On 10/11/2024 7:53 AM, Shengjiu Wang wrote:
> Irq handler need to be executed as fast as possible, so
> the log in irq handler is better to use dev_dbg which needs
> to be enabled when debugging.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
Reviewed-by: Iuliana Prodan <iuliana.prodan@....com>

Thanks,
Iulia
> ---
>   sound/soc/fsl/fsl_esai.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
> index a65f5b9935a2..0b247f16a163 100644
> --- a/sound/soc/fsl/fsl_esai.c
> +++ b/sound/soc/fsl/fsl_esai.c
> @@ -119,10 +119,10 @@ static irqreturn_t esai_isr(int irq, void *devid)
>   		dev_dbg(&pdev->dev, "isr: Transmission Initialized\n");
>   
>   	if (esr & ESAI_ESR_RFF_MASK)
> -		dev_warn(&pdev->dev, "isr: Receiving overrun\n");
> +		dev_dbg(&pdev->dev, "isr: Receiving overrun\n");
>   
>   	if (esr & ESAI_ESR_TFE_MASK)
> -		dev_warn(&pdev->dev, "isr: Transmission underrun\n");
> +		dev_dbg(&pdev->dev, "isr: Transmission underrun\n");
>   
>   	if (esr & ESAI_ESR_TLS_MASK)
>   		dev_dbg(&pdev->dev, "isr: Just transmitted the last slot\n");