linux-kernel - Re: [PATCH v3 2/3] mmc: mtk-sd: Add two settings in platdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b5bc767907e7643589e1971b4a0114ddaf777db.camel@mediatek.com>
Date: Fri, 11 Oct 2024 00:51:38 +0000
From: Andy-ld Lu (卢东) <Andy-ld.Lu@...iatek.com>
To: "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Wenbin Mei (梅文彬) <Wenbin.Mei@...iatek.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-mmc@...r.kernel.org"
	<linux-mmc@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v3 2/3] mmc: mtk-sd: Add two settings in platdata

On Thu, 2024-10-10 at 14:18 +0200, AngeloGioacchino Del Regno wrote:
> Il 09/10/24 14:01, Andy-ld Lu ha scritto:
> > There are modified register settings for STOP_DLY_SEL and
> > POP_EN_CNT,
> > with two new fields added to the compatibility structure to reflect
> > the modifications.
> > 
> > For legacy SoCs, also add the original value of 'stop_dly_sel' to
> > the
> > platdata, for unified code setting.
> > 
> 
> mmc: mtk-sd: Add stop_dly_sel and pop_en_cnt to platform data
> 
> that's a better title; then, in the commit description, you should
> describe
> why stop_dly_sel/pop_en_cnt is overridden (so, why some SoCs need a
> different
> value for those registers).
> 
> Also, this commit should come *before* adding support for MT8196: you
> first
> add the two settings in platdata explaining that this is also done in
> preparation for adding support for the SD/MMC controller found in
> MT8196,
> then you add the acutal MT8196 support.
> 
> For this commit, anyway, the code itself looks good.
> 
> Cheers,
> Angelo

Thanks for your suggestion, I will follow your comment in next change.
> 
>