linux-kernel - Re: [PATCH] selftests: timers: Remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANDhNCr5X3gkSRR7cWZ13DDbepV3Nb1tQ5E3XuAaJx_5vZ=PCw@mail.gmail.com>
Date: Fri, 11 Oct 2024 17:47:01 -0700
From: John Stultz <jstultz@...gle.com>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: Chen Ni <nichen@...as.ac.cn>, tglx@...utronix.de, sboyd@...nel.org, 
	anna-maria@...utronix.de, frederic@...nel.org, shuah@...nel.org, 
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests: timers: Remove unneeded semicolon

On Fri, Oct 11, 2024 at 4:00 PM Shuah Khan <skhan@...uxfoundation.org> wrote:
>
> On 10/10/24 01:37, Chen Ni wrote:
> > Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
> > semantic patch at scripts/coccinelle/misc/semicolon.cocci.
> >
> > Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> > ---
> >   tools/testing/selftests/timers/set-timer-lat.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/timers/set-timer-lat.c b/tools/testing/selftests/timers/set-timer-lat.c
> > index 5365e9ae61c3..7a1a2382538c 100644
> > --- a/tools/testing/selftests/timers/set-timer-lat.c
> > +++ b/tools/testing/selftests/timers/set-timer-lat.c
> > @@ -79,7 +79,7 @@ char *clockstring(int clockid)
> >               return "CLOCK_BOOTTIME_ALARM";
> >       case CLOCK_TAI:
> >               return "CLOCK_TAI";
> > -     };
> > +     }
> >       return "UNKNOWN_CLOCKID";
> >   }
> >
>
> Looks good to me.
>
> John, I will apply this for next of you are okay with it.

Acked-by: John Stultz <jstultz@...gle.com>

> Also I noticed clockstring() is defined in multiple tests.
> Any thoughts on removing the duplicates and adding it to
> a header file? This will add a dependency on another source
> file, but might be good to remove the duplicate code.

Sure, no objections.
-john