linux-kernel - RE: [PATCH v15] pwm: opencores: Add PWM driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <ZQ0PR01MB12538557D7C48C3B2ABEFBA89F7A2@ZQ0PR01MB1253.CHNPR01.prod.partner.outlook.cn>
Date: Sat, 12 Oct 2024 08:02:57 +0000
From: William Qiu <william.qiu@...rfivetech.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>, Hal Feng
	<hal.feng@...rfivetech.com>, Philipp Zabel <p.zabel@...gutronix.de>
Subject: RE: [PATCH v15] pwm: opencores: Add PWM driver support



> -----Original Message-----
> From: William Qiu
> Sent: 2024年10月11日 18:43
> To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> Cc: linux-kernel@...r.kernel.org; linux-pwm@...r.kernel.org; Hal Feng
> <hal.feng@...rfivetech.com>; Philipp Zabel <p.zabel@...gutronix.de>
> Subject: RE: [PATCH v15] pwm: opencores: Add PWM driver support
> 
> > +static void __iomem *starfive_get_ch_base(void __iomem *base,
> +					  unsigned int channel)
> >
> > Would be great if all functions had the same prefix. This simplifies
> > debugging with tracing, because you can just enable traces for
> "ocores_pwm_*".
> >
> Will update.

I want to explain something about this. This interface only works on
StarFive boards, so the "starfive" prefix is used, I don't think the
"ocores_pwm" prefix is appropriate here.

Uwe, what do you think?

Best Regards,
William