linux-kernel - Re: [PATCH v15] pwm: opencores: Add PWM driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b6izzukutuhrbgxrhyu6be2wcs364rtrpvp4lenxsq47f5nwjv@bb2d54hjw6ao>
Date: Sat, 12 Oct 2024 14:40:14 +0200
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: William Qiu <william.qiu@...rfivetech.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>, Hal Feng <hal.feng@...rfivetech.com>, 
	Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH v15] pwm: opencores: Add PWM driver support

On Sat, Oct 12, 2024 at 08:02:57AM +0000, William Qiu wrote:
> 
> 
> > -----Original Message-----
> > From: William Qiu
> > Sent: 2024年10月11日 18:43
> > To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> > Cc: linux-kernel@...r.kernel.org; linux-pwm@...r.kernel.org; Hal Feng
> > <hal.feng@...rfivetech.com>; Philipp Zabel <p.zabel@...gutronix.de>
> > Subject: RE: [PATCH v15] pwm: opencores: Add PWM driver support
> > 
> > > +static void __iomem *starfive_get_ch_base(void __iomem *base,
> > +					  unsigned int channel)
> > >
> > > Would be great if all functions had the same prefix. This simplifies
> > > debugging with tracing, because you can just enable traces for
> > "ocores_pwm_*".
> > >
> > Will update.
> 
> I want to explain something about this. This interface only works on
> StarFive boards, so the "starfive" prefix is used, I don't think the
> "ocores_pwm" prefix is appropriate here.
> 
> Uwe, what do you think?

This function is part of the opencores pwm driver, so ocores_pwm_ is an
appropriate prefix.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)