linux-kernel - [PATCH] crypto: virtio/akcipher - Move a pointer assignment in virtio_crypto_rsa_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <80b91321-138c-41de-95c7-47c3be07fe76@web.de>
Date: Sat, 12 Oct 2024 10:06:37 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: virtualization@...ts.linux.dev, linux-crypto@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>, Eugenio Pérez
 <eperezma@...hat.com>, Gonglei <arei.gonglei@...wei.com>,
 Herbert Xu <herbert@...dor.apana.org.au>, Jason Wang <jasowang@...hat.com>,
 lei he <helei.sig11@...edance.com>, "Michael S. Tsirkin" <mst@...hat.com>,
 Nathan Chancellor <nathan@...nel.org>, Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>, zhenwei pi <pizhenwei@...edance.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] crypto: virtio/akcipher - Move a pointer assignment in
 virtio_crypto_rsa_set_key()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Sat, 12 Oct 2024 09:51:58 +0200

Move the reset of the data structure member “n” to a null pointer
into an if branch so that this assignment will be performed only after
a key parsing failure.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/crypto/virtio/virtio_crypto_akcipher_algs.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
index 48fee07b7e51..56557d4778b0 100644
--- a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
+++ b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
@@ -355,7 +355,6 @@ static int virtio_crypto_rsa_set_key(struct crypto_akcipher *tfm,

 	/* mpi_free will test n, just free it. */
 	mpi_free(rsa_ctx->n);
-	rsa_ctx->n = NULL;

 	if (private) {
 		keytype = VIRTIO_CRYPTO_AKCIPHER_KEY_TYPE_PRIVATE;
@@ -365,8 +364,10 @@ static int virtio_crypto_rsa_set_key(struct crypto_akcipher *tfm,
 		ret = rsa_parse_pub_key(&rsa_key, key, keylen);
 	}

-	if (ret)
+	if (ret) {
+		rsa_ctx->n = NULL;
 		return ret;
+	}

 	rsa_ctx->n = mpi_read_raw_data(rsa_key.n, rsa_key.n_sz);
 	if (!rsa_ctx->n)
--
2.46.1