linux-kernel - Re: [PATCH] tools/resolve_btfids: Fix 'variable' may be used uninitialized warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zwoub8GniNhTF1gu@f39>
Date: Sat, 12 Oct 2024 10:08:15 +0200
From: Eder Zulian <ezulian@...hat.com>
To: Sam James <sam@...too.org>
Cc: acme@...hat.com, andrii@...nel.org, ast@...nel.org, bpf@...r.kernel.org,
	daniel@...earbox.net, eddyz87@...il.com, haoluo@...gle.com,
	john.fastabend@...il.com, jolsa@...nel.org, kpsingh@...nel.org,
	linux-kernel@...r.kernel.org, martin.lau@...ux.dev, sdf@...ichev.me,
	song@...nel.org, vmalik@...hat.com, williams@...hat.com,
	yonghong.song@...ux.dev,
	Michael Weiß <michael.weiss@...ec.fraunhofer.de>
Subject: Re: [PATCH] tools/resolve_btfids: Fix 'variable' may be used
 uninitialized warnings

Hi Sam, thank you for pointing it out.

On Sat, Oct 12, 2024 at 05:14:29AM +0100, Sam James wrote:
> The parse-options change was sent before as
> https://lore.kernel.org/all/20240731085217.94928-1-michael.weiss@aisec.fraunhofer.de/

Sorry, I missed Michael's patch.
My suggestion is to initialize 'o' to NULL instead. An illegal dereferencing
(if any) would then be evident.

> but seems to have fallen through the cracks.
> 
> 
Would it be better to revert this part and wait a bit for Michael's patch to
be merged, please let me know.

Thank you,
Eder