linux-kernel - Re: [PATCH] tools/resolve_btfids: Fix 'variable' may be used uninitialized warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87iktvlcv5.fsf@gentoo.org>
Date: Mon, 14 Oct 2024 01:58:06 +0100
From: Sam James <sam@...too.org>
To: Eder Zulian <ezulian@...hat.com>
Cc: acme@...hat.com,  andrii@...nel.org,  ast@...nel.org,
  bpf@...r.kernel.org,  daniel@...earbox.net,  eddyz87@...il.com,
  haoluo@...gle.com,  john.fastabend@...il.com,  jolsa@...nel.org,
  kpsingh@...nel.org,  linux-kernel@...r.kernel.org,  martin.lau@...ux.dev,
  sdf@...ichev.me,  song@...nel.org,  vmalik@...hat.com,
  williams@...hat.com,  yonghong.song@...ux.dev,  Michael Weiß
 <michael.weiss@...ec.fraunhofer.de>
Subject: Re: [PATCH] tools/resolve_btfids: Fix 'variable' may be used
 uninitialized warnings

Eder Zulian <ezulian@...hat.com> writes:

> Hi Sam, thank you for pointing it out.
>
> On Sat, Oct 12, 2024 at 05:14:29AM +0100, Sam James wrote:
>> The parse-options change was sent before as
>> https://lore.kernel.org/all/20240731085217.94928-1-michael.weiss@aisec.fraunhofer.de/
>
> Sorry, I missed Michael's patch.
> My suggestion is to initialize 'o' to NULL instead. An illegal dereferencing
> (if any) would then be evident.

Yeah, I was wondering the same.

>
>> but seems to have fallen through the cracks.
>> 
>> 
> Would it be better to revert this part and wait a bit for Michael's patch to
> be merged, please let me know.

I'll defer to the maintainers.

>
> Thank you,
> Eder