linux-kernel - Re: [PATCH 3/6] spi: do not initialize device chipselects to SPI_INVALID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZwpPFfJ_h29NxdMJ@finisterre.sirena.org.uk>
Date: Sat, 12 Oct 2024 11:27:33 +0100
From: Mark Brown <broonie@...nel.org>
To: Jonas Gorski <jonas.gorski@...il.com>
Cc: Amit Kumar Mahapatra <amit.kumar-mahapatra@....com>,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] spi: do not initialize device chipselects to
 SPI_INVALID_CS

On Sat, Oct 12, 2024 at 11:53:37AM +0200, Jonas Gorski wrote:
> Now that we know the number of valid chipselects, we don't need to
> initialize them to SPI_INVALID_CS to be able to know if they are valid,
> so we can drop both the initialization to SPI_INVALID_CS, as well as the
> check for it.

Dropping the check is fine but it seems useful to set a poison value to
unused chip selects for robustness.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)