linux-kernel - Re: [PATCHv6 net-next 2/7] net: ibm: emac: remove custom init/exit functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241012125910.GD77519@kernel.org>
Date: Sat, 12 Oct 2024 13:59:10 +0100
From: Simon Horman <horms@...nel.org>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew@...n.ch>,
	Shannon Nelson <shannon.nelson@....com>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>,
	Breno Leitao <leitao@...ian.org>,
	Jeff Johnson <quic_jjohnson@...cinc.com>,
	Christian Marangi <ansuelsmth@...il.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv6 net-next 2/7] net: ibm: emac: remove custom init/exit
 functions

On Fri, Oct 11, 2024 at 12:56:17PM -0700, Rosen Penev wrote:
> c092d0be38f4f754cdbdc76dc6df628ca48ac0eb introduced EPROBE_DEFER

The preferred way to cite commits in patch descriptions is like this:

commit c092d0be38f4 ("net: ibm: emac: remove all waiting code")

Something like this in gitconfig can be helpful.

[core]
	abbrev = 12
[pretty]
	quote = commit %h (\"%s\")
[alias]
	quote = log -1 --pretty=quote

Then the following should work:

$ git quote c092d0be38f4f754cdbdc76dc6df628ca48ac0eb
commit 71eb7f699755 ("net: ibm: emac: use netif_receive_skb_list")

> support. Because of that, we can defer initialization until all modules
> are ready instead of handling it explicitly with custom init/exit
> functions.
> 
> As a consequence of removing explicit module initialization and
> deferring probe until everything is ready, there's no need for custom
> init and exit functions.
> 
> There are now module_init and module_exit calls but no real change in
> functionality as these init and exit functions are no longer directly
> called by core.
> 
> Signed-off-by: Rosen Penev <rosenp@...il.com>

Otherwise, LGTM.