linux-kernel - Re: [PATCHv6 net-next 5/7] net: ibm: emac: use devm for mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241012124345.GC77519@kernel.org>
Date: Sat, 12 Oct 2024 13:43:45 +0100
From: Simon Horman <horms@...nel.org>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew@...n.ch>,
	Shannon Nelson <shannon.nelson@....com>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>,
	Breno Leitao <leitao@...ian.org>,
	Jeff Johnson <quic_jjohnson@...cinc.com>,
	Christian Marangi <ansuelsmth@...il.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv6 net-next 5/7] net: ibm: emac: use devm for mutex_init

On Fri, Oct 11, 2024 at 12:56:20PM -0700, Rosen Penev wrote:
> It seems since inception that mutex_destroy was never called for these
> in _remove. Instead of handling this manually, just use devm for
> simplicity.
> 
> Signed-off-by: Rosen Penev <rosenp@...il.com>
> ---
>  drivers/net/ethernet/ibm/emac/core.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c
> index f8478f0026af..b9ccaae61c48 100644
> --- a/drivers/net/ethernet/ibm/emac/core.c
> +++ b/drivers/net/ethernet/ibm/emac/core.c
> @@ -3021,8 +3021,14 @@ static int emac_probe(struct platform_device *ofdev)
>  	SET_NETDEV_DEV(ndev, &ofdev->dev);
>  
>  	/* Initialize some embedded data structures */
> -	mutex_init(&dev->mdio_lock);
> -	mutex_init(&dev->link_lock);
> +	err = devm_mutex_init(&ofdev->dev, &dev->mdio_lock);
> +	if (err)
> +		return err;

Hi Rosen,

It looks like this should be:

		goto err_gone;

> +
> +	err = devm_mutex_init(&ofdev->dev, &dev->link_lock);
> +	if (err)
> +		return err;

Ditto.

> +
>  	spin_lock_init(&dev->lock);
>  	INIT_WORK(&dev->reset_work, emac_reset_work);

-- 
pw-bot: cr