linux-kernel - Re: [PATCH net-next v2 5/5] net: phy: intel-xway: add support for PHY LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ee4f92f-aaf4-436a-bc1e-23fcb24e22ca@lunn.ch>
Date: Sat, 12 Oct 2024 19:30:20 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Xu Liang <lxu@...linear.com>,
	Christian Marangi <ansuelsmth@...il.com>,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Robert Marko <robimarko@...il.com>,
	Russell King <rmk+kernel@...linux.org.uk>,
	Jacek Anaszewski <jacek.anaszewski@...il.com>,
	linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 5/5] net: phy: intel-xway: add support for
 PHY LEDs

On Thu, Oct 10, 2024 at 01:55:29PM +0100, Daniel Golle wrote:
> The intel-xway PHY driver predates the PHY LED framework and currently
> initializes all LED pins to equal default values.
> 
> Add PHY LED functions to the drivers and don't set default values if
> LEDs are defined in device tree.
> 
> According the datasheets 3 LEDs are supported on all Intel XWAY PHYs.
> 
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> ---

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew