linux-kernel - Re: [PATCH] bcachefs: Simplify code in bch2_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4iwneao62n6xuniitihvhp7ojvt2pkjtisnrnax7hyzztyktxm@yn4unwrqqjpb>
Date: Sat, 12 Oct 2024 13:30:52 -0400
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Youling Tang <youling.tang@...ux.dev>
Cc: linux-bcachefs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Youling Tang <tangyouling@...inos.cn>
Subject: Re: [PATCH] bcachefs: Simplify code in bch2_dev_alloc()

On Sat, Oct 12, 2024 at 03:59:02PM GMT, Youling Tang wrote:
> From: Youling Tang <tangyouling@...inos.cn>
> 
> - Remove unnecessary variable 'ret'.
> - Remove unnecessary bch2_dev_free() operations.
> 
> Signed-off-by: Youling Tang <tangyouling@...inos.cn>

the 'goto err' style is more readable when you're staring at tons of
code