linux-kernel - Re: [PATCH 1/2] ALSA: emu10k1: add a capability bit for no MIDI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c8264f56944c9e739bb494fd98df65b227ca30f.camel@icenowy.me>
Date: Sun, 13 Oct 2024 18:04:34 +0800
From: Icenowy Zheng <uwu@...nowy.me>
To: Oswald Buddenhagen <oswald.buddenhagen@....de>
Cc: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ALSA: emu10k1: add a capability bit for no MIDI

在 2024-10-13星期日的 11:54 +0200，Oswald Buddenhagen写道：
> On Sun, Oct 13, 2024 at 09:47:12AM +0800, Icenowy Zheng wrote:
> > +++ b/sound/pci/emu10k1/emu10k1.c
> > @@ -133,7 +133,9 @@ static int snd_card_emu10k1_probe(struct
> > pci_dev *pci,
> >                 if (err < 0)
> >                         return err;
> >         }
> > -       if (emu->audigy) {
> > +       if (emu->card_capabilities->no_midi) {
> > +               dev_info(emu->card->dev, "Card has no ext. MIDI
> > ports.\n");
> > 
> seems like excess verbosity. there are much more important things
> that
> are not reported.
> 
> > +       } else if (emu->audigy) {
> > 
> i would eliminate that, and instead populate the card table properly.
> that's a bit more code, but it's more uniform, and the resulting
> binary
> is even a tiny bit smaller.

Well in fact I just insert this here to prevent a re-indent of the
following MIDI code.

Well it could be better to be a 
```
if (!emu->card_capabilities->no_midi) {
        The original code
}
```

> 
> also, i would squash the patches, as i see no point in having them
> separate, given their size.
> 
> regards