[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADxym3Z4kyVh2W60ub2QtzcRXHCmFfhmprht0_p_bBdbiJVM0A@mail.gmail.com>
Date: Mon, 14 Oct 2024 20:30:57 +0800
From: Menglong Dong <menglong8.dong@...il.com>
To: Ido Schimmel <idosch@...dia.com>
Cc: kuba@...nel.org, aleksander.lobakin@...el.com, horms@...nel.org,
davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
dsahern@...nel.org, dongml2@...natelecom.cn, amcohen@...dia.com,
gnault@...hat.com, bpoirier@...dia.com, b.galvani@...il.com,
razor@...ckwall.org, petrm@...dia.com, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
Subject: Re: [PATCH net-next v7 12/12] net: vxlan: use kfree_skb_reason() in encap_bypass_if_local()
On Sun, Oct 13, 2024 at 9:24 PM Ido Schimmel <idosch@...dia.com> wrote:
>
> On Wed, Oct 09, 2024 at 10:28:30AM +0800, Menglong Dong wrote:
> > Replace kfree_skb() with kfree_skb_reason() in encap_bypass_if_local, and
> > no new skb drop reason is added in this commit.
> >
> > Signed-off-by: Menglong Dong <dongml2@...natelecom.cn>
> > Reviewed-by: Simon Horman <horms@...nel.org>
> > Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
> > ---
> > drivers/net/vxlan/vxlan_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> > index da4de19d0331..f7e94bb8e30e 100644
> > --- a/drivers/net/vxlan/vxlan_core.c
> > +++ b/drivers/net/vxlan/vxlan_core.c
> > @@ -2341,7 +2341,7 @@ static int encap_bypass_if_local(struct sk_buff *skb, struct net_device *dev,
> > DEV_STATS_INC(dev, tx_errors);
> > vxlan_vnifilter_count(vxlan, vni, NULL,
> > VXLAN_VNI_STATS_TX_ERRORS, 0);
> > - kfree_skb(skb);
> > + kfree_skb_reason(skb, SKB_DROP_REASON_VXLAN_INVALID_HDR);
>
> Shouldn't this be SKB_DROP_REASON_VXLAN_VNI_NOT_FOUND ?
>
Enn.....It should be SKB_DROP_REASON_VXLAN_VNI_NOT_FOUND. I even wonder
why I used SKB_DROP_REASON_VXLAN_INVALID_HDR here.
It seems that we need a new version, and I'll follow you comment
in the other patches of this series too.
Thanks!
Menglong Dong
> >
> > return -ENOENT;
> > }
> > --
> > 2.39.5
> >
Powered by blists - more mailing lists