linux-kernel - Re: [PATCH v4 1/2] arm64: dts: rockchip: Add rk3588-orangepi-5b device tree and refactor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172891445477.1127378.13874736914700071280.robh@kernel.org>
Date: Mon, 14 Oct 2024 09:05:30 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Cenk Uluisik <cenk.uluisik@...glemail.com>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, devicetree@...r.kernel.org, 
 Heiko Stuebner <heiko@...ech.de>, Chris Morgan <macromorgan@...mail.com>, 
 Andy Yan <andyshrk@....com>, Jagan Teki <jagan@...eble.ai>, 
 linux-arm-kernel@...ts.infradead.org, Tim Lunn <tim@...thertop.org>, 
 linux-rockchip@...ts.infradead.org, Dragan Simic <dsimic@...jaro.org>, 
 Jonas Karlman <jonas@...boo.se>, 
 Michael Riesch <michael.riesch@...fvision.net>, Jing Luo <jing@...g.rocks>, 
 Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org, 
 Jimmy Hon <honyuenkwun@...il.com>
Subject: Re: [PATCH v4 1/2] arm64: dts: rockchip: Add rk3588-orangepi-5b
 device tree and refactor


On Mon, 14 Oct 2024 13:29:55 +0200, Cenk Uluisik wrote:
> Implements a slightly modified rk3588s-orangepi-5b.dts
> from the vendor. Unfortunately the &wireless_bluetooth
> and &wireless_wlan are not implemented yet.
> 
> Bigger parts of the rk3588s-orangepi-5.dts file were
> moved into a new rk3588s-orangepi-5.dtsi file, so
> that both device trees from the orangepi-5 and 5b
> include from it and avoid including from the .dts.
> 
> This changes the Orange Pi 5's sdmmc alias to be mmc1,
> breaking existing users if they used the /dev/mmc0 device
> file, so it's consistent with all the other rk3588 DTS,
> which, is also the new default that rockchip wants to use.
> https://github.com/orangepi-xunlong/linux-orangepi/commit/bce92d16b230b8e93c2831fb7768839fd7bbab04
> Therefore also add the sdhc alias to be mmc0 on the
> rk3588s-orangepi-5b.dts.
> 
> How does this board differ from the original Orange Pi 5?
>   - the Orange Pi 5 has a M.2 NVMe M-key PCI 2.0x1
>     slot (hooked to combphy0_ps) whereas the Orange Pi 5b uses combphy0_ps
>     for the WiFi.
>   - The Orange Pi 5 with the M.2 socket has a regulator defined hooked to
>     "GPIO0_C5" (i.e. PCIE_PWREN_H) whereas the Orange Pi 5B has GPIO0_C5
>     hooked to BT_WAKE_HOST.
>   - builtin eMMC storage
>   - no SPI NOR flash (u-boot, preboot etc. initiates
>       from within the eMMC
>       storage)
>   - ap6275p Wifi module (like the Orange Pi 5 Plus)
>   - builtin BlueTooth module
> 
> Signed-off-by: Cenk Uluisik <cenk.uluisik@...glemail.com>
> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../boot/dts/rockchip/rk3588s-orangepi-5.dts  | 798 +-----------------
>  ...orangepi-5.dts => rk3588s-orangepi-5.dtsi} |  36 +-
>  .../boot/dts/rockchip/rk3588s-orangepi-5b.dts |  27 +
>  4 files changed, 73 insertions(+), 789 deletions(-)
>  rewrite arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts (95%)
>  copy arch/arm64/boot/dts/rockchip/{rk3588s-orangepi-5.dts => rk3588s-orangepi-5.dtsi} (96%)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y rockchip/rk3588s-orangepi-5.dtb rockchip/rk3588s-orangepi-5b.dtb' for 20241014113026.78853-1-cenk.uluisik@...glemail.com:

arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dtb: gpio-func: leds-gpio: {'rockchip,pins': [[0, 2, 0, 245]], 'phandle': 253} is not of type 'array'
	from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dtb: vcc-3v3-sd-s0-regulator: Unevaluated properties are not allowed ('enable-active-low' was unexpected)
	from schema $id: http://devicetree.org/schemas/regulator/fixed-regulator.yaml#