linux-kernel - Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add Orange Pi 5b enum to Orange Pi 5 entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALWfF7+DzqYYPZAE4zGMX3jUnbzG+tUEuAJeMQM0_Chn_Vq04w@mail.gmail.com>
Date: Mon, 14 Oct 2024 12:06:17 -0500
From: Jimmy Hon <honyuenkwun@...il.com>
To: Cenk Uluisik <cenk.uluisik@...glemail.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>, 
	Chris Morgan <macromorgan@...mail.com>, Jonas Karlman <jonas@...boo.se>, Andy Yan <andyshrk@....com>, 
	Tim Lunn <tim@...thertop.org>, Jagan Teki <jagan@...eble.ai>, Dragan Simic <dsimic@...jaro.org>, 
	Michael Riesch <michael.riesch@...fvision.net>, Jing Luo <jing@...g.rocks>, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add Orange Pi 5b enum
 to Orange Pi 5 entry

> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 687823e58c22..62bb6587da8f 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -1051,7 +1051,9 @@ properties:
>
>        - description: Xunlong Orange Pi 5
>          items:
> -          - const: xunlong,orangepi-5
> +          - enum:
> +              - xunlong,orangepi-5
> +              - xunlong,orangepi-5b
>            - const: rockchip,rk3588s

As Krzysztof mentioned in v3. The binding commit should come before
the devicetree commit. You'll want to reorder your commits. Otherwise,
if you git bisect, you can get an error with only the devicetree
updates without the changes to the bindings.