linux-kernel - Re: [PATCH v4 1/2] arm64: dts: rockchip: Add rk3588-orangepi-5b device tree and refactor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALWfF7JNcNi5Gs04V5arJQEw89MJKPy6oRDxh-jdtmo-oCAu0A@mail.gmail.com>
Date: Mon, 14 Oct 2024 12:38:59 -0500
From: Jimmy Hon <honyuenkwun@...il.com>
To: Cenk Uluisik <cenk.uluisik@...glemail.com>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, devicetree@...r.kernel.org, 
	Heiko Stuebner <heiko@...ech.de>, Chris Morgan <macromorgan@...mail.com>, Andy Yan <andyshrk@....com>, 
	Jagan Teki <jagan@...eble.ai>, linux-arm-kernel@...ts.infradead.org, 
	Tim Lunn <tim@...thertop.org>, linux-rockchip@...ts.infradead.org, 
	Dragan Simic <dsimic@...jaro.org>, Jonas Karlman <jonas@...boo.se>, 
	Michael Riesch <michael.riesch@...fvision.net>, Jing Luo <jing@...g.rocks>, 
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org, 
	"Rob Herring (Arm)" <robh@...nel.org>
Subject: Re: [PATCH v4 1/2] arm64: dts: rockchip: Add rk3588-orangepi-5b
 device tree and refactor

> New warnings running 'make CHECK_DTBS=y rockchip/rk3588s-orangepi-5.dtb rockchip/rk3588s-orangepi-5b.dtb' for 20241014113026.78853-1-cenk.uluisik@...glemail.com:
>
> arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dtb: gpio-func: leds-gpio: {'rockchip,pins': [[0, 2, 0, 245]], 'phandle': 253} is not of type 'array'
>         from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
Regarding the "leds-gpio" warning, DTS checking script might not like
that id. You could probably avoid it by naming it "green-led". Similar
to what the Orange Pi 5 Plus does. This would be a separate bugfix
commit before any of the other changes in this series.

> arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dtb: vcc-3v3-sd-s0-regulator: Unevaluated properties are not allowed ('enable-active-low' was unexpected)
>         from schema $id: http://devicetree.org/schemas/regulator/fixed-regulator.yaml#
The enable-active-low has already been addressed in
https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v6.12-armsoc/dtsfixes&id=f4d29bebaa6118c1e51e8f1c21ce2b34f43e1479
So you can avoid the error if you start with v6.12-armsoc as your baseline.

Regarding the "leds-gpio" warning, DTS checking script might not like
that id. You could probably avoid it by naming it "green-led". Similar
to what the Orange Pi 5 Plus does. This would be a separate bugfix
commit before any of the other changes.

Jimmy