linux-kernel - Re: [PATCH v3] PCI: starfive: Enable PCIe controller's runtime PM before probing host bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ba5148d-8a82-4312-8fcb-45cb7ca34b5e@quicinc.com>
Date: Mon, 14 Oct 2024 10:40:12 -0700
From: Mayank Rana <quic_mrana@...cinc.com>
To: Bjorn Helgaas <helgaas@...nel.org>
CC: <kevin.xie@...rfivetech.com>, <lpieralisi@...nel.org>, <kw@...ux.com>,
        <manivannan.sadhasivam@...aro.org>, <robh@...nel.org>,
        <bhelgaas@...gle.com>, <linux-pci@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_krichai@...cinc.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH v3] PCI: starfive: Enable PCIe controller's runtime PM
 before probing host bridge

Hi Bjorn

On 10/14/2024 10:23 AM, Bjorn Helgaas wrote:
> On Mon, Oct 14, 2024 at 09:26:07AM -0700, Mayank Rana wrote:
>> PCIe controller device (i.e. PCIe starfive device) is parent to PCIe host
>> bridge device. To enable runtime PM of PCIe host bridge device (child
>> device), it is must to enable parent device's runtime PM to avoid seeing
>> the below warning from PM core:
>>
>> pcie-starfive 940000000.pcie: Enabling runtime PM for inactive device
>> with active children
>>
>> Fix this issue by enabling starfive pcie controller device's runtime PM
>> before calling pci_host_probe() in plda_pcie_host_init().
>>
>> Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>
>> Signed-off-by: Mayank Rana <quic_mrana@...cinc.com>
>> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> 
> I want this in the same series as Krishna's patch to turn on runtime
> PM of host bridges.  That's how I know they need to be applied in
> order.  If they're not in the same series, they're likely to be
> applied out of order.Thank you for quick response and suggestion.


Hi Krishna

Please add this proposed change as part of your changes to enable 
runtime PM of host bridges.

Regards,
Mayank