lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2lxrtu6mnzs4v6h3x7skbmxwtdmhgn7g3qmmxyr5n4lof6lkb2@6rfckn2g45ho>
Date: Mon, 14 Oct 2024 22:05:40 +0200
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Thierry Reding <thierry.reding@...il.com>, 
	"open list:PWM SUBSYSTEM" <linux-pwm@...r.kernel.org>, 
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, 
	"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>, justin.chen@...adcom.com
Subject: Re: [PATCH 0/2] pwm: brcmstb: Support configurable open-drain mode

Hello Florian,

On Fri, Oct 11, 2024 at 07:56:01PM -0700, Florian Fainelli wrote:
> This patch series updates the pwm-brcmstb driver to not assume an
> open-drain mode, but instead get that sort of configuration from Device
> Tree using the 'open-drain' property.

Just for me to be sure to understand correctly: A kernel without your
patch #2 behaves identical to a kernel with that patch if the open-drain
property is present, right?

It's not clear to me why totem-pole is the better default and the commit
logs don't justify the updated default. Can you improve here?

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ