[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMRc=MeoSnr-z=fmfRoTU-vdL_BAkTAE+0HiBaVUWmFG-bOTPw@mail.gmail.com>
Date: Mon, 14 Oct 2024 09:48:16 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Kent Gibson <warthog618@...il.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v2 5/6] gpiolib: switch the line state notifier to atomic
On Mon, Oct 14, 2024 at 4:11 AM Kent Gibson <warthog618@...il.com> wrote:
> >
> > + /*
> > + * This is called from atomic context (with a spinlock taken by the
> > + * atomic notifier chain). Any sleeping calls must be done outside of
> > + * this function in process context of the dedicated workqueue.
> > + *
> > + * Let's gather as much info as possible from the descriptor and
> > + * postpone just the call to pinctrl_gpio_can_use_line() until the work
> > + * is executed.
> > + */
> > +
>
> Should be in patch 4? You aren't otherwise changing that function here.
>
Until this patch, the comment isn't really true, so I figured it makes
more sense here.
Bart
Powered by blists - more mailing lists