linux-kernel - Re: [PATCH v4] rust: add global lock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875xpylmac.fsf@kernel.org>
Date: Fri, 11 Oct 2024 16:57:47 +0200
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "Benno Lossin" <benno.lossin@...ton.me>
Cc: "Alice Ryhl" <aliceryhl@...gle.com>,  "Miguel Ojeda" <ojeda@...nel.org>,
  "Boqun Feng" <boqun.feng@...il.com>,  "Gary Guo" <gary@...yguo.net>,
  Björn Roy Baron <bjorn3_gh@...tonmail.com>,
  <rust-for-linux@...r.kernel.org>,  <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] rust: add global lock support

"Benno Lossin" <benno.lossin@...ton.me> writes:

> On 10.10.24 16:01, Andreas Hindborg wrote:
>> "Benno Lossin" <benno.lossin@...ton.me> writes:
>>
>>>
>>> Also,
>>>
>>>     error: type `__static_lock_ty_VALUE` should have an upper camel case name
>>>        --> rust/kernel/sync/lock/global.rs:100:18
>>>         |
>>>     100 |               type [< __static_lock_ty_ $name >] = $valuety;
>>>         |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `StaticLockTyValue`
>>>
>>
>> How did you manage to get these errors?
>
> I added a `global_lock!` invocation to `lib.rs`. Otherwise I also don't
> get them (they might also be emitted from the examples, but I didn't
> compile those).

I build the examples for kunit, but I did not get any warnings.
Interesting.

BR Andreas