linux-kernel - Re: [PATCH v2 0/2] staging: vchiq_arm: Fix missing refcount decrement in error path for fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21116939-a868-4df2-8824-2b56f7ea68c1@ideasonboard.com>
Date: Mon, 14 Oct 2024 14:56:51 +0530
From: Umang Jain <umang.jain@...asonboard.com>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Stefan Wahren <wahrenst@....net>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: linux-rpi-kernel@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2 0/2] staging: vchiq_arm: Fix missing refcount decrement
 in error path for fw_node

Hi Javier,

Thank you for the patch

On 14/10/24 2:26 pm, Javier Carrasco wrote:
> This series refactors some useless goto instructions as a preparation
> for the fix of a missing of_node_put() by means of the cleanup
> attribute.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>

For the series,

Reviewed-by: Umang Jain <umang.jain@...asonboard.com>
> ---
> Changes in v2:
> - Refactor vchiq_probe() to remove goto instructions.
> - Declare and initialize the node right before its first usage.
> - Link to v1: https://lore.kernel.org/r/20241013-vchiq_arm-of_node_put-v1-1-f72b2a6e47d0@gmail.com
>
> ---
> Javier Carrasco (2):
>        staging: vchiq_arm: refactor goto instructions in vchiq_probe()
>        staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node
>
>   .../vc04_services/interface/vchiq_arm/vchiq_arm.c     | 19 +++++++------------
>   1 file changed, 7 insertions(+), 12 deletions(-)
> ---
> base-commit: d61a00525464bfc5fe92c6ad713350988e492b88
> change-id: 20241013-vchiq_arm-of_node_put-60a5eaaafd70
>
> Best regards,