linux-kernel - Re: [PATCH v2 0/2] efi/libstub: fix efi_parse_options() ignoring the default command line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXGbuZnM8GoHasWNxs2YOnUDL-JViRmvGdVc91WHkMbdqA@mail.gmail.com>
Date: Mon, 14 Oct 2024 11:55:11 +0200
From: Ard Biesheuvel <ardb@...nel.org>
To: Jonathan Marek <jonathan@...ek.ca>
Cc: linux-efi@...r.kernel.org, Aditya Garg <gargaditya08@...e.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, "Borislav Petkov (AMD)" <bp@...en8.de>, Ingo Molnar <mingo@...nel.org>, 
	Kees Cook <kees@...nel.org>, "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, 
	Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>, 
	open list <linux-kernel@...r.kernel.org>, Nikolay Borisov <nik.borisov@...e.com>
Subject: Re: [PATCH v2 0/2] efi/libstub: fix efi_parse_options() ignoring the
 default command line

On Sun, 13 Oct 2024 at 21:25, Jonathan Marek <jonathan@...ek.ca> wrote:
>
> On 10/13/24 1:30 PM, Ard Biesheuvel wrote:
> > On Sun, 13 Oct 2024 at 07:16, Jonathan Marek <jonathan@...ek.ca> wrote:
> >>
> >> v2:
> >>   - changed to check for NUL character instead of size==1
> >>   - reworked cleanup patch to remove cmd_line_len
> >>   - moved 3rd commit out of this series
> >>
> >> Jonathan Marek (2):
> >>    efi/libstub: fix efi_parse_options() ignoring the default command line
> >>    efi/libstub: remove unnecessary cmd_line_len from
> >>      efi_convert_cmdline()
> >>
> >
> > Thanks. I'm inclined to fold these together and just merge them as a
> > single patch. Any objections?
> >
>
> No objections (its not important to me, but if you want to get the fix
> into stable I think the separate commits makes that easier?)

Yeah good point. I am not going to send these out as fixes anyway,
given that they affect boot behavior, and there are some other things
to fix.