linux-kernel - Re: [PATCH 1/2] media: dt-bindings: Remove assigned-clock-* from various schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ab163df-baec-4fbc-9612-fbff9b092cb5@kernel.org>
Date: Mon, 14 Oct 2024 12:34:51 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Martin Kepplinger <martink@...teo.de>,
 Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
 "Paul J. Murphy" <paul.j.murphy@...el.com>,
 Daniele Alessandrelli <daniele.alessandrelli@...el.com>,
 Tommaso Merciai <tomm.merciai@...il.com>,
 Martin Hecht <martin.hecht@...et.eu>, Zhi Mao <zhi.mao@...iatek.com>,
 Alain Volmat <alain.volmat@...s.st.com>,
 Mikhail Rudenko <mike.rudenko@...il.com>,
 Ricardo Ribalda <ribalda@...nel.org>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Umang Jain <umang.jain@...asonboard.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
 Dongchun Zhu <dongchun.zhu@...iatek.com>,
 Quentin Schulz <quentin.schulz@...obroma-systems.com>,
 Todor Tomov <todor.too@...il.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] media: dt-bindings: Remove assigned-clock-* from
 various schema

On 14/10/2024 12:20, Sakari Ailus wrote:
> Hi Krzysztof,
> 
> On Mon, Oct 14, 2024 at 09:43:07AM +0200, Krzysztof Kozlowski wrote:
>> On Sat, Oct 12, 2024 at 04:02:50PM +0100, Bryan O'Donoghue wrote:
>>> diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
>>> index 60f19e1152b33128cf3baa15b8c70a874ca6d52e..d18ead8f7fc43bfacc291aed85b5ca9166c46edb 100644
>>> --- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
>>> +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
>>> @@ -28,12 +28,6 @@ properties:
>>>      items:
>>>        - description: Reference to the mclk clock.
>>>  
>>> -  assigned-clocks:
>>> -    maxItems: 1
>>> -
>>> -  assigned-clock-rates:
>>> -    maxItems: 1
>>> -
>>>    reset-gpios:
>>>      description: Reference to the GPIO connected to the RESETB pin. Active low.
>>>      maxItems: 1
>>> @@ -82,8 +76,6 @@ required:
>>>    - compatible
>>>    - reg
>>>    - clocks
>>> -  - assigned-clocks
>>> -  - assigned-clock-rates
>>
>> That's not extraneous, but has a meaning that without assigned-clocks
>> this device or driver will not operate.
>>
>> File should rather stay as is.
> 
> ...
> 
>>> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
>>> index c978abc0cdb35cfe2b85069946cf1be435a58cb8..f0f9726a2add89492b8c56e17ed607841baa3a0d 100644
>>> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
>>> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
>>> @@ -24,10 +24,6 @@ properties:
>>>        - sony,imx258
>>>        - sony,imx258-pdaf
>>>  
>>> -  assigned-clocks: true
>>> -  assigned-clock-parents: true
>>> -  assigned-clock-rates: true
>>> -
>>
>> This is ok.
> 
> Basically the clock related requirements for these devices are the same:
> they all need a clock configured at a board specific frequency. Shouldn't
> we treat them the same way?

I don't know these devices, but binding did not express such
requirement, so according to current binding the properties are 100%
redundant.

Best regards,
Krzysztof