linux-kernel - Re: [PATCH 2/2] media: dt-bindings: Use additionalProperties: false for endpoint: properties:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9525ac5c-5cae-4e4f-baf5-f81e4ffd4dbd@kernel.org>
Date: Mon, 14 Oct 2024 12:37:12 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>, Shawn Guo
 <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Martin Kepplinger <martink@...teo.de>,
 Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
 "Paul J. Murphy" <paul.j.murphy@...el.com>,
 Daniele Alessandrelli <daniele.alessandrelli@...el.com>,
 Tommaso Merciai <tomm.merciai@...il.com>,
 Martin Hecht <martin.hecht@...et.eu>, Zhi Mao <zhi.mao@...iatek.com>,
 Alain Volmat <alain.volmat@...s.st.com>,
 Mikhail Rudenko <mike.rudenko@...il.com>,
 Ricardo Ribalda <ribalda@...nel.org>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Umang Jain <umang.jain@...asonboard.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
 Dongchun Zhu <dongchun.zhu@...iatek.com>,
 Quentin Schulz <quentin.schulz@...obroma-systems.com>,
 Todor Tomov <todor.too@...il.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] media: dt-bindings: Use additionalProperties: false
 for endpoint: properties:

On 14/10/2024 11:03, Bryan O'Donoghue wrote:
> On 14/10/2024 09:47, Krzysztof Kozlowski wrote:
>> If a common binding for a group of devices encourages you to list its
>> subset, then it is not that common.
>>
>> Solution is to fix that, e.g. split it per classes of devices.
> 
> It might be possible to have
> 
>           $ref: /schemas/media/video-interfaces-endpoint-defaults.yaml#
> 
> which declares the typical list ->
> 
> $ref: /schemas/media/video-interfaces.yaml#
> additonalProperties:false

I meant something else - define common schema matching this class of
devices. Not a schema for some defaults. This is supposed to reflect how
we look at hardware, not some library of schemas or library of functions.

> 
> properties:
>      data-lanes: true
>      link-frequencies: true
>      remote-endpoints: true

and I still don't like all these. I rather expect people to list the
hardware constraints or just drop it. I mentioned it some time ago in
the first patch you sent, which I think started this entire discussion.

> 
> required:
>      data-lanes
>      link-frequencies
>      remote-endpoints
> 
> and then if you need say clock-noncontinuous you'd just include
> 
> $ref: /schemas/media/video-interfaces.yaml#
> unevaluatedProperties: false
> 
> and then list whatever you need
> 
>> Or don't care and use unevaluatedProps because it makes people's life
>> easier and is still correct. If it is not correct, then this should be
>> used as an argument.
> 
> I'll wait to see what people think before progressing this patch further.

Best regards,
Krzysztof